Unit: tests FTBFS: `make tests` lacks a dependency

[thresheek]

On c42525ede054:

thresh@coal projects/nginx/unit $ ./configure --tests && make -j1 tests
configuring for Linux 5.2.0-2-amd64 x86_64
checking for C compiler: cc
 + using GNU C compiler
 + gcc version 9.2.1 20190909 (Debian 9.2.1-8) 
building an "echo" program
checking for int size ... 4
checking for long size ... 8
checking for long long size ... 8
checking for void * size ... 8
checking for size_t size ... 8
checking for off_t size ... 8
checking for time_t size ... 8
checking for C99 variadic macro ... found
checking for GCC __builtin_expect() ... found
checking for GCC __builtin_unreachable() ... found
checking for GCC __builtin_prefetch() ... found
checking for GCC __builtin_clz() ... found
checking for GCC __builtin_popcount() ... found
checking for GCC __attribute__ visibility ... found
checking for GCC __attribute__ aligned ... found
checking for GCC __attribute__ malloc ... found
checking for GCC __attribute__ packed ... found
checking for GCC builtin atomic operations ... found
checking for posix_memalign() ... found
checking for Linux malloc_usable_size() ... found
checking for alloca() ... found
checking for Linux mallopt() ... found
checking for MAP_ANON ... found
checking for MAP_POPULATE ... found
checking for MAP_PREFAULT_READ ... not found
checking for shm_open() ... not found
checking for shm_open() in librt ... found
checking for shm_open(SHM_ANON) ... not found
checking for memfd_create() ... found
checking for Linux clock_gettime(CLOCK_REALTIME_COARSE) ... found
checking for FreeBSD clock_gettime(CLOCK_REALTIME_FAST) ... not found
checking for clock_gettime(CLOCK_REALTIME) ... found
checking for Linux clock_gettime(CLOCK_MONOTONIC_COARSE) ... found
checking for FreeBSD clock_gettime(CLOCK_MONOTONIC_FAST) ... not found
checking for clock_gettime(CLOCK_MONOTONIC) ... found
checking for HP-UX hg_gethrtime() ... not found
checking for struct tm.tm_gmtoff ... found
checking for altzone ... not found
checking for localtime_r() ... found
checking for pthread_yield() ... found
checking for pthread spinlock ... found
checking for pthread spinlock zero initial value ... found but is not working
checking for sem_timedwait() ... not found
checking for sem_timedwait() in libpthread ... found
checking for __thread ... found
checking for Linux epoll ... found
checking for Linux signalfd() ... found
checking for Linux eventfd() ... found
checking for kqueue ... not found
checking for Solaris event port ... not found
checking for /dev/poll ... not found
checking for AIX pollset ... not found
checking for AF_INET6 ... found
checking for sockaddr.sa_len ... not found
checking for struct sockaddr size ... 16
checking for struct sockaddr_in size ... 16
checking for struct sockaddr_in6 size ... 28
checking for struct sockaddr_un size ... 110
checking for struct sockaddr_storage size ... 128
checking for socketpair(AF_UNIX, SOCK_SEQPACKET) ... found
checking for struct msghdr.msg_control ... found
checking for sys/filio.h ... not found
checking for ioctl(FIONBIO) ... found
checking for socket(SOCK_NONBLOCK) ... found
checking for accept4() ... found
checking for Linux sendfile() ... found
checking for posix_fadvise() ... found
checking for fcntl(F_READAHEAD) ... not found
checking for fcntl(F_RDAHEAD) ... not found
checking for getrandom() ... found
checking for ucontext ... found
checking for dlopen() ... not found
checking for dlopen() in libdl ... found
checking for posix_spawn() ... found
checking for setproctitle() ... not found
checking for clone(2) ... found
checking for CLONE_NEWUSER ... found
checking for CLONE_NEWNS ... found
checking for CLONE_NEWPID ... found
checking for CLONE_NEWNET ... found
checking for CLONE_NEWUTS ... found
checking for CLONE_NEWCGROUP ... found
checking for Linux capability ... found
creating build/Makefile

Unit configuration summary:

  bin directory: ............. "bin"
  sbin directory: ............ "sbin"
  lib directory: ............. "lib"
  include directory: ......... "include"
  modules directory: ......... "modules"
  state directory: ........... "state"

  pid file: .................. "unit.pid"
  log file: .................. "unit.log"

  control API socket: ........ "unix:control.unit.sock"

  non-privileged user: ....... "nobody"
  non-privileged group: ...... ""

  IPv6 support: .............. YES
  Unix domain sockets support: YES
  TLS support: ............... NO

  process isolation: ......... USER NS PID NET UTS CGROUP

  debug logging: ............. NO

cc -c -pipe -fPIC -fvisibility=hidden -O -W -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wmissing-prototypes -Werror -g   -I src -I build   \
                      \
                     \
-o build/src/test/nxt_tests.o \
-MMD -MF build/src/test/nxt_tests.dep -MT build/src/test/nxt_tests.o \
src/test/nxt_tests.c
In file included from src/test/nxt_tests.c:7:
src/nxt_main.h:12:10: fatal error: nxt_version.h: No such file or directory
   12 | #include <nxt_version.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make: *** [build/Makefile:1277: build/src/test/nxt_tests.o] Error 1
thresh@coal projects/nginx/unit $

[i4ki]

I always used:

$ ./configure --tests && make && make tests && ./build/tests

[hongzhidao]

I always used:

$ ./configure --tests && make && make tests && ./build/tests

It would be great that if just use ./configure && make test, the way of njs does.

[i4ki]

I meant I didn't know it was a bug. I'm new on the project.

[hongzhidao]

@tiago4orion
We all see your great job on isolation feature :)