Uniforms: Regression with rc26

[serkandurusoy]

Somehow, default is not prevented any more on onSubmit and this causes a full page refresh.

[macrozone]

Can you describe the scenario?

Maybe its related to my PR? https://github.com/vazco/uniforms/pull/77

[serkandurusoy]

Well the scenario is simple, the previous behavior was that you'd get a doc passed to your onSubmit handler and that's it. But now there is actual form submission so the page is getting refreshed.

[radekmie]

Just to be sure - it worked in rc.25?

[serkandurusoy]

Oh, I think I had 24 and jumped to 26 just half an hour ago. I did not even notice 25!

[serkandurusoy]

@macrozone I just looked at the changes from that PR and no that seems unrelated

[radekmie]

Yes, it's definitely unrelated @macrozone.

[serkandurusoy]

Haha he almost had a heart atack thinking his first small pr just broke the package, LOL :)

[radekmie]

I've tested rc.26 @serkandurusoy and it worked. I don't know what is going on.

[serkandurusoy]

Hmm, interesting, I'll look at other places in the app that may be causing such behavior. That's a login form so perhaps some reactive update on Meteor.loggingIn or something may actually be the culprit!

I'll close this issue for now and reopen if I can narrow it down to actually something related to uniforms.

Thanks!

[serkandurusoy]

Yep that was it. It seems a Meteor.loggingIn check higher up in the dom tree caused the component get swapped out to something else and then back, which kind of looks like a page refresh in this app.

[radekmie]

Well... Luckily, false alarm.

[macrozone]

@serkandurusoy haha 💯

Yeah, I spent roughly 2-3 hours tracking down this bug and was so suprised that the solution was that easy. That's why i had some trust issues ;-)