Ungoogled-chromium: opensuse/system-libdrm.patch suitable for portable build ?

Created on 26 Oct 2018  路  4Comments  路  Source: Eloston/ungoogled-chromium

@Eloston

In my custom build i add this patch to the portable build (patch_order.list)
opensuse/system-libdrm.patch

Is it suitable to add that to portable release mainstream ?

question

Most helpful comment

Fixed with 94b7493c72a3a5767e8b1bca6c7f160f5449fa02

All 4 comments

Why would you need that patch in your builds of Portable Linux?

What the patch does :

--- a/ui/gfx/native_pixmap_handle.cc
+++ b/ui/gfx/native_pixmap_handle.cc
@@ -12,6 +12,9 @@
 namespace gfx {

 #if defined(OS_LINUX)
+#ifndef DRM_FORMAT_MOD_INVALID
+#define DRM_FORMAT_MOD_INVALID ((1ULL<<56) - 1)
+#endif
 static_assert(NativePixmapPlane::kNoModifier == DRM_FORMAT_MOD_INVALID,
               "gfx::NativePixmapPlane::kNoModifier should be an alias for"
"DRM_FORMAT_MOD_INVALID");

Why it does what it does :
DRM_FORMAT_MOD_INVALID is part of the linux kernel https://github.com/torvalds/linux/blob/master/include/uapi/drm/drm_fourcc.h and was introduced in 4.14 https://github.com/torvalds/linux/commit/e6fc3b68558e4c6d8d160b5daf2511b99afa8814#diff-94ab8a47ff02fa7f35cb0451290e1d85 this patch permit compatibility backward post v4.14

Why
The patch is not really tied to opensuse... its why i suggested adding it to the portable, i am using this on my personal build its why i just asked here may be it would be useful...

I see. I'll include it then.

Fixed with 94b7493c72a3a5767e8b1bca6c7f160f5449fa02

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Eloston picture Eloston  路  4Comments

lipici picture lipici  路  3Comments

Darthagnon picture Darthagnon  路  3Comments

biziclop picture biziclop  路  3Comments

tonowoe picture tonowoe  路  3Comments