Umbraco-cms: Save button doesn't work in Content Type Editor (when using non-live MB mode)

[skttl]

When using a non-live ModelsBuilder mode, the save button in the content type editor is changed to a split button, where you can save and generate models.

Clicking Save here doesn't do anything. If I choose save and generate models, it saves and generates models as expected. After this, the save button is reset to the original state (without the split), and then the save button works. again.

Umbraco version

I am seeing this issue on Umbraco version: 8.9.0

[skttl]

Seems like the split button is missing a click-handler

This is how the regular button looks

[nathanwoulfe]

@skttl that makes sense - buttons work a lot better when they have something to do...

Marking it up-for-grabs 😄

[bjarnef]

I am seing this issue as well in Umbraco v8.9.0 after switching ModelsBuilder mode from default PureLive mode to AppData mode.
It seems the save button is showing the spinner sometimes after the application has been recycled (e.g. via ModelsBuilder "Generate models" button), but not on subsequent clicks.

[DanDiplo]

Yep, I'm getting this with AppData mode. Clicking button does absolutely nothing.

Surely this is a critical issue and not an "up-for-grabs" issue, though, as it completely breaks being able to develop with Umbraco?

[nul800sebastiaan]

Sorry I missed this one, this looks like a regression we should look at!

[OwainWilliams]

Fixed in #9300

Thanks for raising the issue @skttl and for other reproducing it.
Thanks @matthew-darby for fixing it.

h5yr

[nul800sebastiaan]

Cherry picked for 8.9.2 and merged up to 8.10.0 as well 👍