Umbraco-cms: V8.5.1: Ambiguous extension method signature between embedded and external ModelsBuilder

[sniffdk]

The IPublishedContent .Value extension method that takes an Expression> parameter is duplicated in the new embedded ModelsBuilder.
Due to them being in the same namespace, there is an ambiguous call between the two, as the method signatures are identical.
Screenshots below:

[nul800sebastiaan]

Thanks again Mads, we're looking into it!

[ronaldbarendse]

This issue is now fixed in PR #7470 by renaming the Umbraco.ModelsBuilder.Embedded version of Value(...) to ValueFor(...):

https://github.com/umbraco/Umbraco-CMS/blob/41dc8d915bdcadb628e6dde9422586310ac66a1b/src/Umbraco.ModelsBuilder.Embedded/PublishedElementExtensions.cs#L20

[clausjensen]

Closing this one - fixed (final fix) in 8.5.3 😄

[bielu]

@nul800sebastiaan This one should be flagged as braking change name of Extension method was changed, which means we break code which was using that.

[nul800sebastiaan]

Okay, done.