Umbraco-cms: U8: Log Viewer pie chart has the wrong verbiage.

[bmargevicius]

Not a big deal but ...
Settings -> Log Viewer -> Right side shows Number of errors and a pie chart of error counts.
There is a label called "Critical" this is incorrect. It should be labeled "Fatal".

You can see this when you click "All Logs". Also ILogger doesn't have the ability to log "critical"

[nul800sebastiaan]

Sure thing, should be fixed up! 👍

[umbrabot]

Hi @bmargevicius,

We're writing to let you know that we've added the Up For Grabs label to your issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly PR team bot :-)

[nathanwoulfe]

Will fix this shortly.

[nathanwoulfe]

Will make the colours consistent too, between the chart and the dropdown

[AndyButland]

@nathanwoulfe and I have overlapped here, but now I've prepared the changes before seeing what he has done, figured may as well PR too and HQ can decide whether to pull in the one I've done after his. I've also fixed the issue noted here, as well as made a few other minor improvements to the log viewer, as described in the PR.

[nathanwoulfe]

@AndyButland I see no reason why both shouldn't be merged - where we overlap, so be it, but we both addressed additional bits as well so between us add more value than either individually 😁

Would be helpful if contributors could self-assign issues, or mark them as in progress to avoid collisions... @nul800sebastiaan could make that a reality I'm sure...

[nul800sebastiaan]

Wish I could, GitHub won't allow it though. I'd actually love it if one of you could send a PR with their changes to the other one so that any merge conflicts are resolved between you too. Wishful thinking? 😁

[nathanwoulfe]

I should be able to merge @AndyButland's branch into mine, resolve conflicts and away we go...