Ublock: Make Ctrl + S save changes to My Filters

[Industry]

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

It would be nice if Ctrl + S applied changes in My Filters instead of opened the "Save Webpage" Dialogue like it does in chrome.

One or more specific URLs where the issue occurs

chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/dashboard.html#1p-filters.html

Screenshot in which the issue can be seen

https://i.imgur.com/eI4RsJT.png instead of actually saving

Steps for anyone to reproduce the issue

Head over to the settings page -> My Filters and press Ctrl S

Your settings

• Browser/version: Chrome 50.0.2661.102 m on Win 10 x64
• uBlock Origin version: uBlock Origin v1.7.2
  

  Your filter lists

N/A

Your custom filters (if any)

[lewisje]

The first question is whether it's possible to override that shortcut, because it's used by the browser itself.

[tophf]

whether it's possible to override that shortcut, because it's used by the browser itself

Chrome/Chromium allows overriding of all shortcuts except Ctrl-Tab/N/T/W (switch tabs, open a new window, open a new tab, close the tab). However, it's not the case with some chromium forks that define their own shortcut management feature (Vivaldi, for example).

[Fohroer]

How about Ctrl+Enter?

[lewisje]

Ctrl+S is probably better to override: Ctrl+Enter normally opens the selected link in a new tab.

[gorhill]

From my last experience with creating built-in shortcuts, I will declined. What works well in one language/keyboard layout might not be true in others.

[gorhill]

I started to use CodeMirror, and keboard shortcut to save came for free as a result. So Ctrl-S (or equivalent in other OSes) is now available in "My filters" with 8d5ebf44efb7.