Uassets: twitter.com: cover Japanese too

[Yuki2718]

URL(s) where the issue occurs

https://twitter.com/

Describe the issue

Please expand the current rules for promoted tweets in uBlock filters to cover Japanese too.

Screenshot(s)

Unfortunately I can't reproduce now, but the rules are obvious.

Notes

twitter.com##:xpath(//span[(text()='Promoted' or text()='Gesponsert' or text()='Реклама' or text()='Promocionado' or text()='Sponsorisé' or text()='Uitgelicht' or text()='推荐' or text()='プロモーション')]/../../../../..)
twitter.com##[data-testid="trend"]:has-text(/推荐|Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht|プロモーション/):xpath(..)

Why don't you update the first rule to
twitter.com##span:has-text(/推荐|Promoted|Gesponsert|Реклама|Promocionado|Sponsorisé|Uitgelicht|プロモーション/):upward(5)?

[dimisa-RUAdList]

It looks like this rule hides the unnecessary on the home page if the user is not logged in: https://i.imgur.com/UusfVoM.jpg

[krystian3w]

@mapx- / @okiehsch / @uBlock-user filter break homepage in Russia.

|
--- | ---
blank PC | blank "mobile." "subdomain"

DOM logger and picker (found link in footer):

|
--- | ---

[mapx-]

@dimisa-RUAdList
if I remove Реклама from the filter bellow is it ok ?

twitter.com##:xpath(//span[(text()='Promoted' or text()='Gesponsert' or text()='Реклама' or text()='Promocionado' or text()='Sponsorisé' or text()='Uitgelicht' or text()='推荐' or text()='プロモーション')]/../../../../..)

[dimisa-RUAdList]

Yes, in this case the home page does not break. True, I do not know what will happen with the promo posts.

[mapx-]

I don't know how to test it, I changed the language in FF, chose a russian ip..

[krystian3w]

Just install the Russian language in the settings, move on top in pop-up, restart Firefox, refresh Twitter page without cache (Ctrl+F5).

Editing only the intl.locale.requested entry seems to no work without a language pack...

[krystian3w]

Change lang on account is here:

https://twitter.com/settings/language

[llacb47]

It's easy, just do this @mapx-

https://twitter.com/?lang=ru (homepage logged out)

To test ads when logged in:

http://twitter.com/home?lang=ru
https://twitter.com/meduzaproject?lang=ru

[Yuki2718]

Is it Russian specific?

[krystian3w]

Uses Реклама / "Reklama".

---

Is it Russian specific?

Yes, these laout use same word for ads and self-promotion.

|
--- |

---

PS. Poland use /^Promowane$/.

[krystian3w]

EL now use:

twitter.com##div[data-testid="placementTracking"]:has(svg + div[dir="auto"] > span:has-text(/Promoted|Gesponsert|Promocionado|Sponsorisé|Sponsorizzato|Promowane|Promovido|Реклама|Uitgelicht|Sponsorlu|Mainostettu|推廣|推广|推薦|推荐/))
                                          twitter.com##div[data-testid="UserCell"]:has-text(/Promoted|Gesponsert|Promocionado|Sponsorisé|Sponsorizzato|Promowane|Promovido|Реклама|Uitgelicht|Sponsorlu|Mainostettu|推廣|推广/)

But they are also reluctant to collect all twitter translations into one filter: https://github.com/easylist/easylist/pull/5456

[Yuki2718]

An anonymous user reported a leftover of promoted tweet which I could reproduce (but not always):

I'm aware of this comment but in this case I guess span:has-text is really necessary as no useful attributes found in parent or grand-parent - as you see aria-label will be language-dependent. upward(3) is minimum-working, upward(6) maximum. So it's possible just to add "プロモツイート" to the current xpath rule as it's equivalent to upward(5). Making "プロモーション" to "プロモ" should also work but IDK if it's safe against FP as I don't use Twitter. If making "Promoted" to "Prom" is safe in English, it'll also be safe. So far I don't see English version - expected as "プロモツイート" means "Promoted tweet".