Uassets: Blocking web-RTC

[nanastasija]

URL(s) where the issue occurs

P2P TURN server IP address (don't want to share publicly)

Describe the issue

I am writing to complain about your ungrounded blocking of web-rtc turn requests that we used for P2P system. We recently noticed our P2P TURN servers have been blocked by uBlock. Millions of users are affected because they are not related to some particular domain, but for all. Instead of domains, TURN servers must be used by IP address, maybe due to this TURN requests are stopped. Web-rtc requests shouldn't be blocked, they don't contain any ads or harmful data, it simply consists of signaling data in order to establish communication. In order to solve the problem, please contact me on [email protected]. I consider your tech should unblock our IP address. Best Regards

Screenshot(s)

[Screenshot(s) for difficult to describe visual issues are mandatory. Post links instead of Inline Images for Screenshots containing Adult material.]

Versions

• Browser/version: [ Google Chrome 75.0.3770.100]
• uBlock Origin version: [1.20.0]

Settings

• [List here all the changes you made to uBO's default settings]

Notes

[filter is: $webrtc,domain]

[mapx-]

• uBo does not support $webrtc ($webrtc is used by easylist list hence supported by adblock, ABP, ublock clone)
• maybe you are talking about ublock clone / spam version ?
• we need real test pages to check your issue
• uBo has its own web rtc management but using a scriptlet nowebrtc.js

[krystian3w]

maybe mistaken with $websocket?

https://github.com/uBlockOrigin/uAssets/search?q=%24websocket&type=Code

[uBlock-user]

$websocket doesn't block IP address or webrtc connections, so no. Without posting the URL there's nothing to go on.

[mapx-]

missing feedback, closing

@nanastasija if you still want to provide the necessary info, write here: [email protected]

[gwarser]

Maybe it's about Prevent WebRTC from leaking local IP addresses?

[mapx-]

She's specifically talking about filter is: $webrtc,domain

[nanastasija]

Sorry for the late response. This error occurs only when uBlock Origin is turned on.

In addition I send you the URL, where the issue occurs when the uBlock is on --> http://test.maksolution.net/test/miki/test_janjua.html

[gwarser]

https://github.com/uBlockOrigin/uAssets/commit/d20120f8aab5ec396d022e74064ba69810d39efa

[mapx-]

@nanastasija
you used previously the webrtc channels to push popups => this is the reason on blocking those requests.
https://forums.lanik.us/viewtopic.php?f=62&t=43060

Have you definitely dropped out the malicious use of web rtc requests ?

[mapx-]

If you are positive on the last point above we can update our list.
Sure, you should also report at easylist repository
https://github.com/easylist/easylist/issues

[okiehsch]

http://test.maksolution.net/test/miki/test_janjua.html
what is broken?

[mapx-]

I guess it's about their P2P system (they now are not able anymore to use a p2p network and the users are using directly their centralized server)

[perosr]

Hi All,

I'm writing in behalf of Vidict Media Server.
The problem is not just at janjua.tv domains, we have this issue on other domains where janjua.tv domain is not added in $webrtc filter. Further more, you write above that uBlock do not use filter $webrtc. We can put another domain, which is not blocked by filter $webrtc, but we have the same problem.

The error is on WEb-RTC side, when RTCPeerConnection is trying to connect to server to get connection ICE candidates. We are using simple peer WEB-RTC implementation.

Best Regards
Pero Gjuzelov

[mapx-]

Without real pages, what is broken, how to reproduce the issue .. we cannot help.

[mapx-]

If there is no specific webrtc / nowebrtc filter, could be it's about using the uBo option Prevent WebRTC from leaking local IP addresses

[krystian3w]

@perosr what you see logo addon in your Browser:

uBlock 0.9.5.16 | uBlock Origin 1.20
--- | ---
|

[perosr]

@perosr what you see logo addon in your Browser:
uBlock 0.9.5.16 uBlock Origin 1.20

[perosr]

uce the issue .. we

there is working link.

Here is another link from domain that is not inside $web-rtc filter. What you mean by real page?

http://test.maksolution.net/test/miki/test_ucaster.html

[mapx-]

ucaster is blocked too by uBo scriptlet
ucaster.xyz##+js(nowebrtc.js)

all these filters (nowebrtc scriptlet or ABP-like $webrtc option) born due to malicious use of webrtc channels - pushing all kind of popups / popunders crap

[mapx-]

The fact is how could you convince not only us (uBo) but also easylist authors that you will use web rtc channels only for legitimate use (p2p streaming) and not for pushing crap on the same infrastructure ?!

@gorhill what do you think .. ?

[mapx-]

What you mean by real page?

I mean not test pages (where you present us clean stuff and not - eventually - a mix of legitimate use + malicious use as I explained above)

[perosr]

resent us clean stuff and not - eventually - a mix of legiti

the embedded iframe is real, and you can see the error there. The problem is on all of our supporting domains (just yesterday on all domains where we have p2p, we had 22Millions visits). I can easily block embed script for blockers (ad block, uBlock and etc), but first I want to try to solve the issue - in meaning what shell we change on both side so to avoid blocking (which is the easiest do be done)

[perosr]

ucaster is blocked too by uBo scriptlet
ucaster.xyz##+js(nowebrtc.js)

all these filters (nowebrtc scriptlet or ABP-like $webrtc option) born due to malicious use of webrtc channels - pushing all kind of popups / popunders crap

this doesn't mean that services used by such websites (ucaster.xyz and similar) are also malicious . We are not owners of mention domains above, they just use our services (in this case vidict Peer - www.vidict.net). I understand your point that malicious use should be stopped, but why to block services that is just used by some malicious website?

[krystian3w]

You can create filterlist with

#@#+js(nowebrtc.js)
@@*$webrtc

for visitors? Other story is unlock ads on other sites than only "Vidict Media Server".

[mapx-]

If I understand correctly, you provide a service used by ucaster, janjua etc ? (which ucaster, janjua then could use web rtc too - but separately from your approach - for pushing popups / other crap)

In this case, probably @gorhill could tell us if the basic / legitimate service / server could be whitelisted (which have to be listed ..) and block only the malicious ones.

[perosr]

Hi mapx,
I'm not sure if janjua, ucaster and etc are using WEB-RTC for malicious usage (I think ad companies are doing that and they do have ads in order to support their free streaming services), but even with web-rtc used by js.script not hosted in their websites, the issue still exists. Here is such link:

http://test.maksolution.net/test/miki/test_ucaster_uBlock.html

On this link, vidictPeer.js (where we are making signalling requests) is hosted on vidict.net and still there are same issue with RTC connections

[mapx-]

yeah, the current implementation will kill any web rtc request used by ucaster.
(however, even whitelisting that filter ucaster.xyz#@#+js(nowebrtc.js) I see no vidictPeer.js element )

Only gorhill could tell us what could be done to refine such blockage.

[gorhill]

Isn't this a resource abuse case? To me it looks like it's an attempt to use visitor's bandwidth without their knowledge to serve (pirated?) streaming data to other users.

[perosr]

Isn't this a resource abuse case? To me it looks like it's an attempt to use visitor's bandwidth without their knowledge to serve (pirated?) streaming data to other users.

in vidict terms, we have stated that. We are not use the system differently then peer5 (million dollar company) or Strive. The principle is same everywhere, we are not bouncing out of regular terms and conditions as others. Also, WEB-RTC is under chrome terms as well, so when you decide to use chrome, you give total rights of WEB-RTC as well.

[mapx-]

@perosr for now (I see no popups delivered via webrtc from ucaster + janjua) I'll comment those filters (waiting to have a fix from uBo creator so in a flexible manner distinguish between good / bad guys)

Are there other such servers using vidict which are blocked (and so also vidict requests) ?

[mapx-]

Easylist is blocking (for AB / ABP) janjua, perhaps @ryanbr could remove the $webrtc filter

[uBlock-user]

so when you decide to use chrome, you give total rights of WEB-RTC as well.

There's no such thing as "giving rights", it's illogical and completely biased from a particular person's pov.