Uassets: dailymail.co.uk

[adranger]

URL(s) where the issue occurs

https://www.dailymail.co.uk/health/article-6906593/Governments-plan-ban-junk-food-adverts-9pm-cut-just-TWO-calories-day.html

If you don't see it, open the front page instead and then click on this headline.

Describe the issue

Popup annoyance while browsing on a tablet.

Screenshot(s)

Versions

• Browser/version: Mozilla/5.0 (Android 7.1.2; Tablet; rv:66.0) Gecko/66.0 Firefox/66.0
• uBlock Origin version: uBlock Origin 1.18.16

Settings

Adguard Base + Annoyances + Mobile + Portuguese + Russian + Social + Spyware
uBlock Origin lists

[mapx-]

I cannot reproduce, however test these filters
dailymail.co.uk##+js(abort-on-property-read.js, navigator.userAgent.search)
or
dailymail.co.uk##+js(set-constant.js, navigator.userAgent.search, trueFunc)

[adranger]

That's what they check, but for some reason your rules didn't work. This one did the trick:

dailymail.co.uk##script:contains(We think our Android)

[mapx-]

Your filter is firefox-specific, however that syntax is deprecated but still alive
use instead:
dailymail.co.uk##^script:has-text(We think our Android)

[mapx-]

try (all browsers)

dailymail.co.uk##+js(abort-current-inline-script.js, navigator.userAgent.search)

[kulfoon]

None of the injects defuse the popup (I've tried on the mobile mode on Firefox & Opera), perhaps race condition?

[mapx-]

I guess html filtering in FF is working, right ?
dailymail.co.uk##^script:has-text(We think our Android)

[kulfoon]

Html filtering yes.

[kulfoon]

krystian3w: dailymail.co.uk##+js(abort-on-property-read.js, DM.later)

I've tried it already before my comment https://github.com/uBlockOrigin/uAssets/issues/5321#issuecomment-482563904 and it was not working, also tried several more different injects as well and none was working. If it works for you, this means that definately race condition is the issue.

[mapx-]

yep, I can confirm (emulation), @krystian3w filter is working
dailymail.co.uk##+js(abort-on-property-read.js, DM.later)

but I don't know if breaks something

[kulfoon]

Yes it's working, perhaps I was checking these:
dailymail.co.uk##+js(abort-current-inline-script.js, DM.later, navigator.userAgent.search)
dailymail.co.uk##+js(set-constant.js, DM.later, undefined)
and seeing they're not working I skipped to check abort-on-property-read/write or forgot or just gave up as spent too much time on it (as checked many other filters as well already) or it was not working before and just has started to.

Perhaps this: dailymail.co.uk##+js(abort-on-property-read.js, DM.later.go) will break less.

[mapx-]

Strange, but blocking DM.later.go will break the above page in firefox.
With DM.later I get no visible breakage

[kulfoon]

mapx: https://github.com/uBlockOrigin/uAssets/issues/5321#issuecomment-482739438

I confirm, so it actually breaks more instead of less.

mapx: With DM.later I get no visible breakage

No visible, but funcional breakage for. ex. social buttons not working when clicking them (except the one in the top-left corner), haven't checked deeper what else got broken, but the console is full of errors...

Anyway I've found better / less breakage solutions:
dailymail.co.uk##+js(abort-on-property-read.js, confirm)
dailymail.co.uk##+js(abort-on-property-write.js, confirm)
dailymail.co.uk##+js(set-constant.js, confirm, falseFunc)
dailymail.co.uk##+js(set-constant.js, confirm, noopFunc)

Seems any of them will break less than DM.later,

because there is only one more message which will be broken:

 window.addEventListener("message", function(t) {
      if("object" == typeof t && t.data.fff) {
        if(clearTimeout(t.data.timeoutId), t.data.closeWindow) if(t.data.unsaved_changes) {
          var n = confirm("You have unsaved changes which would be lost. Do you want to continue? \n Press cancel to abort.");
          n && TINY.box.closetbox()
        } else TINY.box.closetbox();
        t.data.reload && window.FFF.init(), t.data.helloAck && (e = !0)
      }
    });

But no guarantee of no other breakages, as there might be other indirectly realted / depedent breakages as well.

BTW. interesting case, this one:
dailymail.co.uk##+js(set-constant.js, confirm, trueFunc)

won't work at all and will prevent the whole website from loading as it gives critical protocol error:

[mapx-]

for firefox is already working, so I'll add for other browsers

!#if !env_firefox
!#if env_mobile
dailymail.co.uk##+js(abort-on-property-read.js, confirm)
!#endif
!#endif

[adranger]

What "other browsers" support this extension on portable devices?

[mapx-]

It should work now.

[kulfoon]

Previous solution https://github.com/uBlockOrigin/uAssets/issues/5321#issuecomment-482795939 was working fine, after last commit, not working on Opera mobile anymore, because mobile Opera meets the both conditions (separately!): it's not Firefox + it's mobile which means the both filters (blocking + exception) are applied, thus the exception filter disables (overrides) the blocking filter... so the blocking filters is not applied because it's whitelisted.

The last commit should be reverted, because in this specific case there is no real issue with the previous commit, even despite the fact the issue theoriticaly has an effect, but practically it has not. The issue's details are here: https://github.com/uBlockOrigin/uBlock-issues/issues/270#issuecomment-429841056 , for example on desktop Opera the second condition !#if env_mobile will be ignored thus the filter won't apply, but hey - the second condition itself does want to be ignored / not applied on the desktop anyway, so the final effect with the issue is the same as the final effect without the issue: filter not applied on desktop browser (I've even checked the logger and it is not applied on the desktop), so the desired effect is kept despite the fact of existence the whole issue.

Actually it is applied on the desktop (I see it in the logger - just forgot to switch to previous version of the Annoyance list: https://raw.githubusercontent.com/uBlockOrigin/uAssets/0809024b166c0ad1b4ceb4f1bcffcec80a907b46/filters/annoyances.txt), but still the rules doesn't work on mobile as mentioned earlier.

[mapx-]

Now:

!#if env_firefox
dailymail.co.uk#@#+js(abort-on-property-read.js, confirm)
!#endif

!#if env_mobile
dailymail.co.uk##+js(abort-on-property-read.js, confirm)
!#endif

If opera mobile, the first one is not enabled but will be enabled the second one.
Note that now we have 2 separate (not combined) blocks.

[kulfoon]

mapx: https://github.com/uBlockOrigin/uAssets/issues/5321#issuecomment-482805542

Ahh yes, stupid eyes mistake..., my eyes mistakenly mixed the old condition (!env) with the new condition (env) especially plus the fact that there is another ! in !#if as well so all these ! eyes-screwed me... thus I took the old one as the current one...+ followed by the fact the popup is still here on Opera Mobile (emulated) = it gave me Fata Morgana that the fault is because of the new commit lolz

krystian3w: What Opera Mobile 51 support uBO? can you explain instruction install addon?

Doesn't it...? I never used Opera Mobile so I didn't know, but Opera Mobile (emulated) does and the popup is still here...lol.

[ghajini]

@mapx-

Platform= firefox A. Ublock origin 1.27.11b10

URL =

https://www.dailymail.co.uk/news/article-8415101/BLM-activists-DEFY-Boris-Johnsons-calls-abandon-protests.html

Issue= this filter dailymail.co.uk##body:style(margin-top: -80px!important;)
from adguard mobile ads filter (part of default on firefox a.)

is breaking hamburger menu at top and social share buttons at top are hidden

Ublock enabled=
https://prnt.sc/syog7v

Adguard mobile ads filter disabled=
https://prnt.sc/syoh8l

[krystian3w]

Wait 1-3 h and update list, problem should gone.