steps to reproduct
problem 1
https://add0n.com/popup-blocker.htmlhttps://www.rapidvideo.com/?v=FKKQ4JUN0Zrapidvideo playerproblem 2
https://www.rapidvideo.com/?v=FKKQ4JUN0Zmy filters
popup strict
ubo 1.14.16 & ubo-pe 12.73
chrome 62.0.3202.89
win10 x64
otakustream.tv,rapidvideo.com##script:inject(abort-current-inline-script.js, parseInt, tabunder)
I can't reproduce an issue with https://www.rapidvideo.com/?v=FKKQ4JUN0Z. Default settings/lists.
There's already a filter for rapidvideo - rapidvideo.com##script:inject(abort-current-inline-script.js, atob, tabunder)
however, I'm still able to reproduce the tabunder on rapidvideo too.
I can't reproduce, someone else will have to investigate. Note that there is no support for when an issue occurs only with another extension -- the filters added to uBO's own filters are those needed when uBO is used alone and with default filter lists/settings.
I disabled all other extensions and it still happens on my end on Chromium 64, but it's fine if you want to keep it closed, I only posted for rapidvideo as I was also able to reproduce the tabunder.
Does your own suggested filter fix your case?
I can't reproduce it on rapidvideo.com, with Firefox, Chrome and Opera
Yes, it does.
Forgot to add, I also have an experimental flag chrome://flags/#enable-framebusting-needs-sameorigin-or-usergesture enabled.
You can read all about it here - https://www.ghacks.net/2017/11/09/enable-unwanted-redirection-protection-in-google-chrome/
I can't reproduce, but I get the 4f6b2af479d337cf.com request, which "normally" leads to popups,
If I add rapidvideo.com##script:inject(abort-current-inline-script.js, parseInt, tabunder) there is no request from 4f6b2af479d337cf.com.
here: https://www.rapidvideo.com/e/FH7AT7LMK1
I get a redirect / tabunder
I cannot find something better than ||rapidvideo.com^$inline-script
rapidvideo.com##script:inject(abort-current-inline-script.js, atob, tabunder)
and this existent filter why does not work ?
rapidvideo.com##script:inject(abort-current-inline-script.js, parseInt, tabunder)
I don't know, the inline script triggering the popunders is basically the same on all sites, as far as I can see.
In all cases either ##script:inject(abort-current-inline-script.js, atob, tabunder) or
##script:inject(abort-current-inline-script.js, parseInt, tabunder) fixes the issue.
Without looking at the code, by the look of it, it could be because sometimes they use built-in base64 decoding (atob), sometimes they use js-based base64 decoding (parseInt).
[edit: removed silly comment, hopefully nobody saw it]
I edited the last chromium uBo release, adding the logger changes here:
https://github.com/gorhill/uBlock/issues/2877#issuecomment-330429588
I switched OFF ublock filters and tested both filters (separately).
The fact is both are logged but only atob / tabunder works.
(function() { var target = 'atob'; if ( target === '' || target === '{{1}}' ) { return; } var needle = 'tabunder', ...
(function() { var target = 'parseInt'; if ( target === '' || target === '{{1}}' ) { return; } var needle = 'tabunder', ....
Ok, about that silly comment... If needed, I could modify the scriptlet to be able to hook into more than one global property:
##script:inject(abort-current-inline-script.js, atob|parseInt, tabunder)
Just ask if you think it would be convenient.
why not if it's not big deal adding multiple global properties
Is it really needed?
In this issue all that is required is hooking into atob or parseInt.
Just my two cents.
Sure, just throwing the idea out there if ever it becomes convenient.
@okiehsch
In this issue all that is required is hooking into atob or parseInt
Am wondering why are there 2 filters for both parseInt and atob in uBO filters then? Is the parseInt filter not needed anymore? Or if it is needed isn't it better like @gorhill suggested to modify scriptlet to use just 1 filter as ##script:inject(abort-current-inline-script.js, atob|parseInt, tabunder)?
I never saw an issue were both were needed, I agree one of the two is probably redundant.
The link - https://www.rapidvideo.com/?v=FKKQ4JUN0Z - provided by the OP does not include the popup script right now, atleast on my end, but such sites rotate their popup/popunder scripts on a regular basis.
I never saw an issue were both were needed,
Happens on https://www4.9anime.is/ on my end, and on every domain where this tabunder script is used. One is just not enough anymore. I have to use the other to neuter it. I hope gorhill considers modifying the scriptlet nonetheless.
9anime.*##script:inject(abort-current-inline-script.js, parseInt, tabunder) works fine on my end, but if this is does not work for everyone then of course I agree, gorhill should modify the scriptlet.
Unfortunately it doesn't, on my end atleast, and everywhere the same script is used, I have been using them in pairs, that's why. It used to work, but I think the author modified it and now it requires two of them.
@gorhill's post https://github.com/uBlockOrigin/uAssets/issues/833#issuecomment-347030057 is true and both can be used on the same website because these webmasters will just keep rotating the scripts. I also agree that modifying the scriplet would be best so we don't have to worry about which one works for who and it will also reduce duplicate filters.
NSFW
https://www.rapidvideo.com/v/G49561S7S8
Popup ads
add the rule
||rapidvideo.com^$script,badfilter
provide a valid reason for your request
because it blocks the scripts on this site, see for yourself
can not play anything. + player's design breaks (it becomes default design from the browser)
I have it in my list for long time, it's a bad filter.
I am pretty sure @mapx- is asking for specific URLs where the filter is causing issues.
@gorhill > https://github.com/uBlockOrigin/uAssets/issues/833#issuecomment-504691489
all urls that have rapidvideo.com
I just tried the URL last posted in thread and it played fine with default filter lists. You need to make the case why ||rapidvideo.com^$script,badfilter is needed, throwing a couple of words is not helpful and just waste time really. Provide all the details, specific URLs, steps to reproduce, and explain exactly what is not working along with screenshots ("player's design breaks" is too vague), otherwise there is nothing actionable.
I will not do this. We have been discussing one filter for too long. I will add to my custom list how the anime boy did.
have a nice day.
RapidVideo sunsetted itself -- https://torrentfreak.com/rapidvideo-shuts-down-following-legal-pressure-from-warner-bros-and-netflix-191021/
@mapx- You may remove all the filters associated with both the domains now.
Most helpful comment
otakustream.tv,rapidvideo.com##script:inject(abort-current-inline-script.js, parseInt, tabunder)