Typescript: Typescript async conversion should watch out for const

[joaomoreno]

TS Template added by @mjbvz

TypeScript Version: 4.2.0-dev.20201116

Search Terms

• quick fix
• suggestion
• convert to async

---

    getCommands(filterUnderscoreCommands: boolean = false): Promise<string[]> {
        this._logService.trace('ExtHostCommands#getCommands', filterUnderscoreCommands);

        return this._proxy.$getCommands().then(result => {
            if (filterUnderscoreCommands) {
                result = result.filter(command => command[0] !== '_');
            }
            return result;
        });
    }

[mjbvz]

Minimal repo:

function getCommands(): Promise<any> {
    return Promise.resolve(1).then(result => {
        result = result + 2;
    });
}

results in:

async function getCommands(): Promise<any> {
    const result = await Promise.resolve(1);
    result = result + 2;
}

[a-tarasyuk]

What the expected result for this issue?

/cc @mjbvz

[joaomoreno]

To use let instead.

[a-tarasyuk]

@joaomoreno Like so?

ts async function getCommands(): Promise<any> { let result = await Promise.resolve(1); result = result + 2; }