autocomplete union wide
In both https://github.com/microsoft/TypeScript/issues/28743 and https://github.com/microsoft/TypeScript/issues/28743 they were correctly closed for being correctly widened to a string.
I'd like to pitch that this is useful only from the IDE experience, and that's purely where the value comes in from. The widening to a string makes sense, however allowing this lets you declare an API where you would like to allow any input, but there are preferred options.
```ts repro
type ErrorStatus = 'not_found' | 'failed' | 'parse_error' | string;
declare function fail(status: ErrorStatus): any
fail("not")
// ^|
```
Would offer "not_found", "failed", "parse_error" in the completion list.
My suggestion meets these guidelines:
keep it broken so people stop writing types like that
There are situations when implementing 3rd party APIS where you know the options that there are right now, but future versions will absolutely add new options.
If you use a closed union type, you get auto completion but errors on every new option that is added. If you use string, you lose auto completion.
How to solve this dilemma?
I say this as someone who extolls the virtues of self-documenting code constantly...
IMO, this is conflating purely documentary concerns with typing concerns. In reality, the type is just string and we shouldn't pretend otherwise. I understand the value of having an automatic list of suggestions, but that feels more like the domain of documentation-level scaffolding such as JSDoc comments, rather than the type system proper.
type ErrorStatus = (('not_found' | 'failed' | 'parse_error') & tag "suggestions") | string;
Whoa, hold on. Will this actually be a use case of tag types? 馃槼
crosslinking to #29729
:wave: Hi, I'm the Repro bot. I can help narrow down and track compiler bugs across releases! This comment reflects the current state of the repro in this issue running against the nightly TypeScript. If something changes, I will post a new comment.
:warning: Assertions:
Historical Information
| Version | Reproduction Outputs |
|---|---|
| 3.5.3, 3.6.4, 3.7.5, 3.8.3, 3.9.5, Nightly | :warning: Assertions: |
Most helpful comment
keep it broken so people stop writing types like that