Typescript: Nested conditional type with generic tuple argument always expands to false branch.

Created on 2 Apr 2019  路  4Comments  路  Source: microsoft/TypeScript


TypeScript Version: next (3.4.0-dev.20190330), latest (3.4.1)


Search Terms:

  • tuple conditional type
  • tuple compare
  • tuple comparison

Code

type Not<T extends boolean> = [T] extends [true] ? false : true;
type NoOp<T extends boolean> = Not<Not<T>>; // always expands true (see intellisense)

type t0 = Not<Not<false>>; // false
type t1 = NoOp<false>;     // true (but should be false)

Expected behavior:
Type t1 must be false and NoOp must be of the nested conditional type that depends on T, but not of simple true unit type.
Actual behavior:
As you see, something is broken when you use generic argument for tuple comparison in conditional type, because when you expand your types manually (t0 is an expanded representation of t1) it works as expected.

Playground Link:

Klick me

Related Issues:

This bug report originated from my stackoverflow question.

Additional credits to @dragomirtitian and @fictitious for helping and localizing the bug to a minimal representation.

Bug

Most helpful comment

This is _technically_ a duplicate of #30020

This issue is closed. just because someone provide a workaround. No one care the bug itself. it may cause some other problem which has not workaround.

All 4 comments

Even smaller repro (perhaps not 'smaller'):

type Inner<T> = [T] extends [true] ? false : true;
type Outer<T> = [Inner<T>] extends [true] ? 1 : 2; // Already resolved to 2.

Most likely the wildcard instantiation for Outer is causing Inner to resolve to false, therefore the condition in Outer is always false under the most permissive instantiation and will resolve to 2.

This is technically a duplicate of #30020

This is _technically_ a duplicate of #30020

This issue is closed. just because someone provide a workaround. No one care the bug itself. it may cause some other problem which has not workaround.

I found a similar issue while writing a conditional type IsOptional to test whether a single property is optional:

// From this answer https://stackoverflow.com/a/52991061/374328

type OptionalKeys<T> = { [K in keyof T]-?: {} extends Pick<T, K> ? K : never }[keyof T];

// Test if a single property on type T is optional

type IsOptional<T, K extends keyof T> = {} extends Pick<T, K> ? true : false;

// example interfaces

interface I {
    x: string;
    y?: number
}

type IX = IsOptional<I, 'x'> // false - ok
type IY = IsOptional<I, 'y'> // true - ok

interface J extends I {
    y: number;
}

type JX = IsOptional<J, 'x'> // false - ok
type JY = IsOptional<J, 'y'> // false - ok

// issue

type TX<T extends I> = IsOptional<T, 'x'>; // expands to false - correct since x required in I
type TY<T extends I> = IsOptional<T, 'y'> // expands to false - incorrect - y might be optional in T

Playground

IsOptional itself seems to work correctly. Type TX expands to false, which while correct may be by accident. However, type TY also expands to false, which is incorrect.

Finally, note that the following implementation of IsOptional doesn't result in the same problems:

type IsOptional<T, K extends keyof T> = K extends OptionalKeys<T> ? true : false;
Was this page helpful?
0 / 5 - 0 ratings

Related issues

dlaberge picture dlaberge  路  3Comments

siddjain picture siddjain  路  3Comments

bgrieder picture bgrieder  路  3Comments

Roam-Cooper picture Roam-Cooper  路  3Comments

DanielRosenwasser picture DanielRosenwasser  路  3Comments