Typescript: TS3.0-RC - VRLayer left/rightBounds type.

[cmerighi]

TypeScript Version: 3.0.0-rc
VRLayer type described in 3.0rc's _lib.dom.d.ts_ conflicts with the one in _@types/webvr-api_. The latter is a devDependency for the widely used _@types/three_.

VRLayer in lib.dom.d.ts:

interface VRLayer {
    leftBounds?: number[] | Float32Array | null;
    rightBounds?: number[] | Float32Array | null;
    source?: HTMLCanvasElement | null;
}

VRLayer in @types/webvr_api/index.d.ts:

interface VRLayer {
    leftBounds?: number[] | null;
    rightBounds?: number[] | null;
    source?: HTMLCanvasElement | null;
}

Looking at the specs, including Float32Array among the piped types seems unnecessary/wrong to me.

[kitsonk]

This all came about due to an issue discussed in Microsoft/TSJS-lib-generator#419 where some browsers adopted earlier versions of the spec which required Float32Array.

[mhegazy]

Should be fixed by https://github.com/Microsoft/TypeScript/pull/25944

[abirmingham]

Is there a workaround for this issue in the meantime? Thanks!

EDIT: Worked around this issue by adding a new type roots folder, with webvr-api/index.d.ts and the Float32Array definition. Will subsequently drop this folder and the erroneous definition.

[efokschaner]

@mhegazy perhaps I'm missing it but I don't see any changes to VRLayer in the pr you mentioned https://github.com/Microsoft/TypeScript/pull/25944 , are you sure it fixes it?

[uniqueiniquity]

@RyanCavanaugh

[kitsonk]

It looks like Microsoft/TSJS-lib-generator#546 hasn't been merged.

[efokschaner]

@kitsonk that pr still seems to include Float32Array in the union https://github.com/Microsoft/TSJS-lib-generator/pull/546/files#diff-a97a9d0dbf71ec2f96be57f7fb9f70c9R1523

So we would still be seeing the same issues we're having right now with the webvr typings, no?

I'd still appreciate some input on how best to reconcile this situation perhaps from @mhegazy or @RyanCavanaugh .

There are three situations that need to be handled by the DT webvr-api typings:

• Use with TS before it had any webvr typings built in.
• Use with later 2.x TS versions which had webvr typings.
• Use with the 3.x TS versions with this changed definition.

Is there any way to satisfy all three? Or should we do a major version bump of the webvr typings and support TS 3 onwards only in the next major version? I've not done a major version bump inside DT before, anything to be aware of if that's our preferred choice here? Is there still a possibility TS 3.x will revert to how it was in 2? @mhegazy and @kitsonk both seem to suggest this may be happening though I'm yet to see a code change that does it.

[efokschaner]

@mhegazy, perhaps we should re-open this issue? We still have the exact issue described. Do you remember what was the motivation for closing the issue?

[markgoho-EDT]

Why is this issue closed when it hasn't been resolved?

[abirmingham]

Bump. Still running into this issue with 3.1.1.

[cmerighi]

Bump. Still running into this issue with 3.1.1.

Updating the dependencies to the following versions, everything runs smoothly:

"devDependencies":{
    "typescript": "3.1.1",
    "@types/three": "^0.92.23",
    /*"@types/webvr-api": "^0.0.34" removed */
    /* [...] others */
}

Given that

• _@types/three_ does not depend on _@types/webvr-api_ anymore https://github.com/DefinitelyTyped/DefinitelyTyped/commit/1b6989809fae020f7fc26a2b361892d25b99f720#diff-b595406edda0ef8d2636cc10dafc4a15, and that
• _@types/webvr-api_ has been modified to match the TypeScript definitions https://github.com/DefinitelyTyped/DefinitelyTyped/commit/822fafc157d3d2e1a8522ab4bfcdf9ee2ac1818d#diff-ac5475b8d8fc8504bffffc73fc5f9601