Typescript: Broken public API in tsserver

[anstarovoyt]

Hi. This commit broke our integration with tsserver. Now the commands are 'phantom' and we cannot reference them in our code. For example we use it here:
https://github.com/JetBrains/intellij-plugins/blob/master/AngularJS/src/ngLanguageService/angular-session.ts#L46

We use own abstraction under tsserver (in fact tsserverlibrary.js) in IDEA / WebStorm / other jetbrains products so a lot of users will be affected.

Is it expected breaking change?
//cc @andy-ms

[anstarovoyt]

rel. https://youtrack.jetbrains.com/issue/WEB-27249

[mhegazy]

can you build against lib\protocol.d.ts instead?

[anstarovoyt]

@mhegazy yes, I can. But it requires to rebuild the app with ts2.4 and unfortunately the version will be broken for all our users WS2017.1 / IDEA2017.1 etc.

[mhegazy]

The file is built with preserveConstEnums, so the enum should still be there. i am not sure i understand the issue.. do you have tsserverlibrary in the same process? if so, after this change is ts.server.protocol.CommandTypes non-existent?

[anstarovoyt]

@mhegazy sorry, I will clarify.
In our javascript (typescript) code we use ts.server.protocol.CommandNames. After the
121b46a8c0f71b73817f429b57e27e61R6 and e3155e304f4c857fb1d9df7fc74154e9L115
ts.server.protocol.CommandNames doesn't exist in runtime.

[mhegazy]

I see the issue now, can you give https://github.com/Microsoft/TypeScript/pull/16409 a try?

[anstarovoyt]

@mhegazy Yes, it works. The version typescript@rc doesn't contain the changes. Is it ok?

[mhegazy]

the next one ([email protected]) will be out in 2 weeks.

[elvisbegovic]

same issue here

[eclimoom]

same issue like
Process: Error processing message: Cannot read property 'getOrCreateScriptInfo' of undefined TypeError: Cannot read property 'getOrCreateScriptInfo' of undefined

[andy-ms]

@eclimoom Could you create a new issue for that and provide instructions to reproduce the error?

[eclimoom]

thank you,
after update my webstorm no this error.