Typescript: Breaking changes in tsserver API between 2.3.0rc and 2.3.1.

Created on 28 Apr 2017  路  6Comments  路  Source: microsoft/TypeScript

Hi. We (WebStorm & Intellij IDEA) use public API of tsserver (in fact we use 'tsserverlibrary.js') and every time when you introduce changes in the public API we have to change our code accordingly.
For example this commit https://github.com/Microsoft/TypeScript/commit/3cc379c3c0c8f3e5ee8b1be5bad8bbc31cfcb610
changed the constructor of the exported class "Session" and we really depend on it.

Could you please not introduce breaking changes in stable branches?
rel. https://youtrack.jetbrains.com/issue/WEB-26641

cc @RyanCavanaugh

Bug Fixed High Priority
Source
picture anstarovoyt
👍16

Most helpful comment

This slipped through unnoticed, and is not intentional. we will try and get a fix for you shortelly. sorry for the hassle.

picture mhegazy on 28 Apr 2017
👍5 ❤1

All 6 comments

This slipped through unnoticed, and is not intentional. we will try and get a fix for you shortelly. sorry for the hassle.

mhegazy picture mhegazy on 28 Apr 2017
👍5 ❤1

@anstarovoyt I'll have a fix up shortly that you can try locally

RyanCavanaugh picture RyanCavanaugh on 28 Apr 2017

TypeScript 2.3.2 should be available now with the fix. sorry for the trouble.

mhegazy picture mhegazy on 29 Apr 2017
❤1

@mhegazy awesome! Thank you

anstarovoyt picture anstarovoyt on 29 Apr 2017

Are you tracking a fix for the root cause here? Seems like there is some missing testing that would have caught the API instability.

alexeagle picture alexeagle on 31 May 2017

yes. we now have tests that baseline the API.

mhegazy picture mhegazy on 4 May 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

weswigham picture weswigham  路  3Comments
remojansen picture remojansen  路  3Comments
manekinekko picture manekinekko  路  3Comments
DanielRosenwasser picture DanielRosenwasser  路  3Comments
Zlatkovsky picture Zlatkovsky  路  3Comments