Turicreate: Image Similarity exported coreml spec includes two useless layer

Created on 20 Nov 2019  路  8Comments  路  Source: apple/turicreate

Coreml model spec for image similarity has two useless layer:
softmax and fc1, which doesn't effect the result but should be removed.

bug good first issue image similarity

Most helpful comment

@nickjong @syoutsey Clearing this out of 6.0.

All 8 comments

@nickjong @jakesabathia2 Is this a 6.0 ship blocker?

@jakesabathia2 Is this a regression from 5.8?

The perf I believe isn't affected.
But 5.8 didn't have those two useless layers.

@jakesabathia2 Actually that makes sense now. Now, we are simply just using the coreml-ml model as is and it has those 2 layers. We should remove them.

Here is s sample output of model exported via TC 5.8 and 6.0. The interfaces are the same but the 2 layers does add some space to the .mlmodel but CoreML optimizes unused layers so it won't have impact on the app.

image

@nickjong @syoutsey Clearing this out of 6.0.

@TobyRoseman, I would like to work on this issue. Thank you!

@kritikadusad - ok, great. I've assigned this issue to you. Let me know if you have any questions.

Was this page helpful?
0 / 5 - 0 ratings