Tui.editor: Toolbar option "Scroll on" should be in I18n

Created on 25 Aug 2020  路  3Comments  路  Source: nhn/tui.editor

Toolbar options should be in I18n

  • Scroll on
  • Scroll off

image

Feature Question
Source
picture hrvoj3e

All 3 comments

@hrvoj3e The scroll sync button ("Scroll on") is currently being handled by CSS, so I think users can override this style for each language.

https://github.com/nhn/tui.editor/blob/855abe661827d423fd3a7e791ba6e5816b8aac46/apps/editor/src/css/editor.css#L297-L308

seonim-ryu picture seonim-ryu on 26 Aug 2020

Seems weird.
IMHO this should be in translation file because it is exposed in GUI in main toolbar.

hrvoj3e picture hrvoj3e on 26 Aug 2020
👍1

@hrvoj3e As you said, I'm going to handle the scroll sync button so that i18n can also be used.

seonim-ryu picture seonim-ryu on 3 Sep 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

existme picture existme  路  3Comments
kelvinkoko picture kelvinkoko  路  3Comments
oguera picture oguera  路  3Comments
igasparetto picture igasparetto  路  4Comments
cyberjacob picture cyberjacob  路  4Comments