Tslint: Accept whitelist for no-implicit-dependencies

Created on 17 Apr 2018 · 5Comments · Source: palantir/tslint

I would like to specify whitelists for no-implicit-dependencies because of webpack externals options.

TypeScript code being linted

import * as i18n from 'i18n-js' // Module 'i18n-js' is not listed as dependency in package.json

// ...

webpack.config.js:

module.exports = {
  // ...

  externals: {
    'i18n-js': 'I18n',
  },

  // ...
}

I guess this rule should accept whitelists as options. However, since the current option only accepts the type of dependencies, this is breaking change.
Is such a feature accepted?

Source

wata727

👍4

Most helpful comment

My use case is slightly different. Assume the following paths in the tsconfig.json:

"paths": {
    "@app/*": ["app/*"],
    "@config/*": ["app/_config/*"],
    "@environment/*": ["environments/*"],
    "@shared/*": ["app/_shared/*"],
    "@helpers/*": ["helpers/*"]
}

Although it won't be easy to parse the paths when linting I'd like to see the whitelist as a workaround which should be a lot easier to implement. no-submodule-imports has a similar whitelist that works for me. Here's hoping no-implicit-dependencies gets some love as well.

ghost on 16 May 2018

👍2

All 5 comments

My use case is slightly different. Assume the following paths in the tsconfig.json:

"paths": {
    "@app/*": ["app/*"],
    "@config/*": ["app/_config/*"],
    "@environment/*": ["environments/*"],
    "@shared/*": ["app/_shared/*"],
    "@helpers/*": ["helpers/*"]
}

ghost on 16 May 2018

👍2

i also find myself disabling no-implicit-dependencies when writing test code which imports from dev dependencies (e.g. enzyme)

suchanlee on 28 Jun 2018

The whitelist should fix this issue, however for @NearAutomata it may still be a problem because the rule handles imports starting with @ differently: https://github.com/palantir/tslint/blob/master/src/rules/noImplicitDependenciesRule.ts#L115