following up from https://github.com/palantir/tslint/pull/1423
adidahiya
All 4 comments
I've been developing fixes by running them across the whole Angular codebase. This helps find a lot of corner cases (like in #1568 I discovered I was deleting license blocks if they were leading trivia on an unused import statement).
We need to have a discussion of a right way for exposing the CLI, but a quick solution for advanced users is to just have a formatter that does this. Then you add -t applyFixes to your CLI command and the fixes are produced and written on the filesystem.
I'll send a PR to upstream that, I think it's a good intermediate solution to allow more people to experiment with fixes. That helps us get fixes implemented in a bunch of rules, which is a co-requisite to getting value out of the CLI for applying them.
alexeagle
on 23 Sep 2016
yeah, I like that approach to get auto-fixing out the door sooner. thanks for the PR.
adidahiya
on 23 Sep 2016
@alexeagle looking forward to the PR, thanks!
jesperronn
on 26 Sep 2016
I believe this was fixed with #1697
nchen63
on 3 Dec 2016
Related issues
adidahiya
路
3Comments
mateiacd
路
3Comments
cretz
路
3Comments
cateyes99
路
3Comments
ghost
路
3Comments
Most helpful comment
I've been developing fixes by running them across the whole Angular codebase. This helps find a lot of corner cases (like in #1568 I discovered I was deleting license blocks if they were leading trivia on an unused import statement).
We need to have a discussion of a right way for exposing the CLI, but a quick solution for advanced users is to just have a formatter that does this. Then you add
-t applyFixesto your CLI command and the fixes are produced and written on the filesystem.I'll send a PR to upstream that, I think it's a good intermediate solution to allow more people to experiment with fixes. That helps us get fixes implemented in a bunch of rules, which is a co-requisite to getting value out of the CLI for applying them.