Tsdx: Compatibility with yarn 2 (or yarn 1 PnP mode)

[xaviergonz]

Current Behavior

Yarn v2 got a stable release today, and it uses PnP (instead of node_modules) exclusively
Right now tsdx test, tsdx build (and maybe others) have some issues with it (specially with finding the typescript package if it is not globally installed, which would be my case).

Desired Behavior

TSDX should work out of the box with yarn v2 / yarn v1 PnP mode

Suggested Solution

Fix TSDX build configurations / upgrade build packages.

Who does this impact? Who is this for?

People who use yarn v1 PNP mode and/or yarn v2.

Describe alternatives you've considered

N/A

[jaredpalmer]

We need special rollup plugins to support this last I checked

--
Jared

---

From: Javier Gonzalez [e-mail]
Sent: Saturday, January 25, 2020 10:01 AM
To: jaredpalmer/tsdx
Cc: Subscribed
Subject: [jaredpalmer/tsdx] Compatibility with yarn 2 (or yarn 1 PnP mode) (#458)

Current Behavior

Yarn v2 got a stable release today, and it uses PnP (instead of node_modules) exclusively
Right now tsdx test, tsdx build (and maybe others) have some issues with it (specially with finding the typescript package if it is not globally installed, which would be my case).

Desired Behavior

TSDX should work out of the box with yarn v2 / yarn v1 PnP mode

Suggested Solution

Fix TSDX build configurations / upgrade build packages.

Who does this impact? Who is this for?

People who use yarn v1 PNP mode and/or yarn v2.

Describe alternatives you've considered

N/A

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/jaredpalmer/tsdx/issues/458?email_source=notifications&email_token=AA67IGYQ4VQNW62XJUJXXN3Q7P5XBA5CNFSM4KLPYZU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIVSHEA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA67IG23I7XTXPC4EL6UNS3Q7P5XBANCNFSM4KLPYZUQ.

[xaviergonz]

Such as this one? https://github.com/arcanis/rollup-plugin-pnp-resolve

[jaredpalmer]

Gonna press pause until this is sorted out: https://github.com/yarnpkg/berry/issues/766#issue-555117544

[kylemh]

It looks like it's been sorted. What're we thinkin on this? It will actually help with #122 a bit because Yarn2 will topologically sort packages for the correct build order before tests (for example). The alternative on v1 is to manually define the correct order 😭

[agilgur5]

I'll mark this as PR welcome. node_modules is referenced in a few places and I know some of our dependencies rely on it too, so I don't think the amount of work for this is trivial. We'd also have to support both versions too, not just Berry. And probably run tests against both versions in CI too.

Not really a high priority given amount of work, other priorities, and that the community hasn't really moved on to Berry as a whole (including little interest in this issue and the fact that it's not the default version).

[timini]

can i leave a bounty?

[timini]

is there any direction / roadmap for someone who wanted to get started with this?

[jaredpalmer]

@timini is there a bounty service you recommend?

[kylemh]

https://issuehunt.io/