Tsdx: please remove eslint-config-react-app from dependencies, it is required only for react projects

[JustFly1984]

warning "tsdx > [email protected]" has unmet peer dependency "[email protected]".
warning "tsdx > [email protected]" has incorrect peer dependency "[email protected]".

[JustFly1984]

also please update @typescript-eslint/[email protected] to 2.0.0

[jaredpalmer]

Can you submit a PR?

[JustFly1984]

@jaredpalmer
Which node version do you use to build? I will add .nvmrc to the project.

I'm running tests and getting an error:

can't update stuff until you fix tests

[skvale]

• eslint-config-react-app is used for more than just React projects
• Bumping @typescript-eslint/eslint-plugin to 2.0.0 has breaking changes not supported by the current version of eslint-config-react-app
• The warning of unmet/incorrect peer dependencies are coming from here: https://github.com/facebook/create-react-app/blob/master/packages/eslint-config-react-app/package.json. babel-eslint doesn't need to be a peer dependency for 100% TypeScript apps and it looks like eslint-plugin-flowtype could be `3.x || 4.x'

[JustFly1984]

@skvale have you tried to run tests?

[skvale]

It looks like the tests are passing from your screenshot

There is a noisy test for an invalid build: https://github.com/palmerhq/tsdx/blob/master/test/fixtures/build-invalid/src/index.ts

[skvale]

re:

also please update @typescript-eslint/[email protected] to 2.0.0

eslint-config-react-app just bumped their versions of typescript-eslint deps: https://github.com/facebook/create-react-app/pull/7540/files

tsdx could bump eslint-config-react-app and @typescript-eslint/eslint-plugin now

[JustFly1984]

it is better to ditch eslint-config-react-app - it messes up linting projects without create-react-app

[agilgur5]

As was written previously above (https://github.com/formium/tsdx/issues/182#issuecomment-526948153), it's definitely not just for React projects -- can view the rules and see for yourself.

I'm not sure what "messes up linting projects without create-react-app" refers to. I'm open to changing to a different default ESLint config (I personally use Standard), however that's a separate story -- please propose an RFC if interested.
It would likely be a very breaking change and folks who use lint configs tend to not want to make stylistic choices themselves and so may be adverse to that. TSDX also has overlap with CRA / CRL users (and has a good bit of inspiration from CRA), so similar config is probably more consistent for those folks.

[JustFly1984]

@agilgur5 the issue for me is mostly out of date versions of dependencies in CRA. I use carefully managed list of eslint plugins myself, and would love to have smaller dependency tree, and less clutter in npm i logs about missing/outdated dependencies.

[agilgur5]

Ok, that's different from "messing up linting"; that would mean it works but just is outdated. #810 has this issue too. I suspect CRA has somewhat of the same issue as TSDX where a major bump in any sub-package causes a major in CRA so as a result you end up being slow to update dependencies as you batch them into majors.
In any case, I don't particularly want to maintain an ESLint config myself for reasons I've written in https://github.com/formium/tsdx/pull/890#issuecomment-703167625 . For ecosystem consistency also would prefer using an existing, well-used config. If you've got suggestions, feel free to make an RFC.