Ts-jest: babel-jest was added to the peer dependencies list

Created on 13 Aug 2018  路  8Comments  路  Source: kulshekhar/ts-jest

babel-jest was added to the peer dependencies list in this commit https://github.com/kulshekhar/ts-jest/commit/fbe4f1f37e6e2f51855bff1ffba552c6739dc7f1 I have doubts that this is really necessary, I do not understand why this was done.

Enhancement

Most helpful comment

@huafu thank you!

Is this any blocking and/or should it be addressed as an emergency?

Everything works well, but it's a little confusing because of the package managers warnings.

All 8 comments

You're right @vkrol since babel-jest ships with babel. There has been a lot of refactoring and there must have been a reason why I had put this but I can't remember any valid one now. I guess this is something to remove in next release.

Is this any blocking and/or should it be addressed as an emergency?

@huafu thank you!

Is this any blocking and/or should it be addressed as an emergency?

Everything works well, but it's a little confusing because of the package managers warnings.

@huafu I think that we need to change the milestone. 23.1.4 was released already.

aye, I forgot about this one, we should just remove it, I think we are not ready to use milestones, too much work haha

I'm getting errors [ts-jest] You must install the 'babel-jest' package if you're using babel.

But I'm not using babel AFAIK.
Is it due to some dependent packages published with module: ... which ts-jest picked up and need babel to transpile?

@unional see https://github.com/kulshekhar/ts-jest#supports-automatic-of-jestmock-calls ;-)

Thanks!

will close in beta, partially solved via #704

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AlexGellert picture AlexGellert  路  4Comments

stangerjm picture stangerjm  路  4Comments

golddranks picture golddranks  路  3Comments

artola picture artola  路  3Comments

jbreckmckye picture jbreckmckye  路  3Comments