Triplea: unit tests are running slow

Created on 9 Oct 2017  路  2Comments  路  Source: triplea-game/triplea

Unit tests lose a lot of effectiveness when they are slow to run. Target should be around 10 to 20 seconds. Given a thousand to 10k unit tests, we need each one to run in 100ms or less.

We've a few particularly slow ones to look at:
slow

Not sure of the options just yet, @ignore is always one but heavy handed and not very desirable. Opening this issue for tracking/visibility in case anyone would like to tackle this.

Most helpful comment

@DanVanAtta This will be covered by the PR I mentioned in #2473. The slow unit tests were actually why I decided to look into how we can improve the speed of lobby authentication. :smile:

All 2 comments

@DanVanAtta This will be covered by the PR I mentioned in #2473. The slow unit tests were actually why I decided to look into how we can improve the speed of lobby authentication. :smile:

Down to 16s now.
Thanks for addressing this @ssoloff , #2473 did the trick.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

DanVanAtta picture DanVanAtta  路  6Comments

ron-murhammer picture ron-murhammer  路  5Comments

DanVanAtta picture DanVanAtta  路  5Comments

Cernelius picture Cernelius  路  8Comments

RoiEXLab picture RoiEXLab  路  3Comments