Trinitycore: [Quest] Garments of Darkness

[gygyti]

Garments of Darkness (5650)
"Find Deathguard Kel and heal his wounds using Lesser Heal (Rank 2). Afterwards, grant him Power Word: Fortitude and then return to Dark Cleric Beryl in Brill."

You will not be able to do this because the spell is cast on you and not on the Deathguard Kel.

https://classic.wowhead.com/quest=5650/garments-of-darkness

3.3.5
Ubuntu x64
Rev. b86b21a

[Aokromes]

https://i.imgur.com/C2lYBHH.png

[illfated]

Unless someone else can confirm this issue (and I will test it myself tomorrow), it is not a likely TC source issue.

[offl]

There is an problem, trying to understand how this is supposed to work

[offl]

UNIT_FLAG_PLAYER_CONTROLLED was removed in https://github.com/TrinityCore/TrinityCore/commit/1f4b5c2f5646c6eaae336b54a762868a71cddb67#diff-2dcdff98f376a2113cc758a2d4cf76b33dfc67524b09a9479bc798582e5ee60cR1-R2
Turned out it's required to cast spells on another friendly faction. For example I created a troll and I'm able to cast spells on Orgrimmar NPCs. But not on Undercity NPCs. I'm not entirely sure how this is supposed to work but UNIT_FLAG_PLAYER_CONTROLLED with no doubt should not be added in DB

Just in case leaving repro steps

There's one quest for priests where you should cast heal spell on Undercity NPC
I created troll priest
.level 79
.learn my trainer
.npc add tem 12428
.q a 5650
find in spellbook Lesser Heal (Rank 2) and try to cast on NPC
spell is casted on player instead

Then I applied

UPDATE creature_Template SET unit_Flags = unit_flags | 8 WHERE entry IN (12428)

.reload creature_Template 12428
.npc add tem 12428
find in spellbook Lesser Heal (Rank 2) and try to cast on NPC
or any other spell
works

I don't have sniff with that creature but it doesn't matter, here's sniff with similar creature which is too required for the same quest but for different faction. No flag, no flags at all

[4] UpdateType: CreateObject1
[4] GUID: Full: 0xF13000308B035C61 Type: Creature Entry: 12427 Low: 220257
[4] Object Type: 3 (Unit)
[4] Update Flags: 96 (Living, StationaryObject)
[4] Movement Flags: 0 (None)
[4] Extra Movement Flags: 0 (None)
[4] Time: 1068626106
[4] Position: X: -5668.6924 Y: -454.09006 Z: 394.46713
[4] Orientation: 1.797689080238342285
[4] Fall Time: 0
[4] Walk Speed: 2.5
[4] Run Speed: 8
[4] RunBack Speed: 4.5
[4] Swim Speed: 4.722222328186035156
[4] SwimBack Speed: 2.5
[4] Turn Speed: 7
[4] Fly Speed: 4.5
[4] FlyBack Speed: 3.141592741012573242
[4] Pitch Speed: 3.141592741012573242
[4] OBJECT_FIELD_GUID: Full: 0xF13000308B035C61 Type: Creature Entry: 12427 Low: 220257
[4] OBJECT_FIELD_TYPE: 9
[4] OBJECT_FIELD_ENTRY: 12427
[4] OBJECT_FIELD_SCALE_X: 1
[4] UNIT_FIELD_BYTES_0: 0/1/0/1
[4] UNIT_FIELD_HEALTH: 100
[4] UNIT_FIELD_POWER3: 100/1.4E-43
[4] UNIT_FIELD_POWER4: 100/1.4E-43
[4] UNIT_FIELD_POWER5: 1000000/1.401298E-39
[4] UNIT_FIELD_MAXHEALTH: 137/1.92E-43
[4] UNIT_FIELD_MAXPOWER3: 100/1.4E-43
[4] UNIT_FIELD_MAXPOWER4: 100/1.4E-43
[4] UNIT_FIELD_MAXPOWER5: 1000000/1.401298E-39
[4] UNIT_FIELD_LEVEL: 7/1E-44
[4] UNIT_FIELD_FACTIONTEMPLATE: 55/7.7E-44 (55)
[4] UNIT_VIRTUAL_ITEM_SLOT_ID: 2557/3.583E-42
[4] UNIT_VIRTUAL_ITEM_SLOT_ID + 2: 2552/3.576E-42
[4] UNIT_FIELD_BASEATTACKTIME: 2000/2.803E-42
[4] UNIT_FIELD_UNK63: 2000/2.803E-42
[4] UNIT_FIELD_BOUNDINGRADIUS: 0.347
[4] UNIT_FIELD_COMBATREACH: 1.5
[4] UNIT_FIELD_DISPLAYID: 12474/1.748E-41
[4] UNIT_FIELD_NATIVEDISPLAYID: 12474/1.748E-41
[4] UNIT_FIELD_BYTES_1: 8/0/0/0
[4] UNIT_MOD_CAST_SPEED: 1065353216/1
[4] UNIT_FIELD_BYTES_2: 1/1/0/0
[4] UNIT_FIELD_HOVERHEIGHT: 1

Then I realized that those quests should not be available for each race and only by corresponding to quest location races, so yeah, this is how this issue is supposed to be fixed

Looks like all other creatures with that flag all are temp summoned so the flag will be added by core, anyway even if any of them are broken, each case should be investigated in separate issues. I doubt there will be more but who knows

[github-actions[bot]]

f474418651557acb621e9634993738118fb54a7e

[gygyti]

still the same problem with quests (f474418)
quests 5650, 5648, 5624, 5625, 9586 still do not work ( tested on a9c83d5 )

[illfated]

TrinityCore rev. e5518b53fa37 2021-02-01 16:15:44 +0200 (3.3.5 branch) (Win64, Release, Static)

Using SSL version: OpenSSL 1.1.1i  8 Dec 2020 (library: OpenSSL 1.1.1i  8 Dec 2020)
Using Boost version: 1.74.0
Using MySQL version: 50732
Using CMake version: 3.19.2
Compiled on: Windows 10.0.19042
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 251987687 bytes
vmaps directory located in ./vmaps. Total size: 658130721 bytes
mmaps directory located in ./mmaps. Total size: 1962379500 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.21011
TC> _

Confirmed. Power Word: Fortitude and Lesser Heal, Rank 2 only targets player, not any friendly NPC targets.

• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=1243/power-word-fortitude
• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=2052/lesser-heal

By the way, just trying to do the quest itself in Brill, regardless of trainer & other quests, it is obvious that the player priest character is unable to cast the required 2 friendly spells on anyone else but player (self). The animation and player stats make it very obvious.

[illfated]

Hmm... starting to wonder if there are very few users (playing the priest class) noticing that there may have been some changes to how healing spells work (or if healing is no longer available on low levels).

[gygyti]

maybe we should reopening this issue?

[offl]

Migrated to #26009