Trinitycore: New Player Experience - Exile's Reach teleport

[DerEnderman]

.

[illfated]

Oh. Right. I was almost going to ask why you are deleting one ID and creating a different one. The ID column is missing in the insert.

-- New Player Experience - Exile's Reach
DELETE FROM `game_tele` WHERE `id`= 1683 AND `map`= 2175;
INSERT INTO `game_tele` (`id`, `position_x`, `position_y`, `position_z`, `orientation`, `map`, `name`) VALUES
(1683, 459.758179, -2620.471191, 0.473076, 0.603843, 2175, 'ExilesReach');

[DerEnderman]

The ID is AutoGenerated by the GameTele Table itself it should always be blank to let the database choose the correct number.

[illfated]

The ID is AutoGenerated by the GameTele Table itself it should always be blank to let the database choose the correct number.

Oh. I see. I did not know that. Good point. Thank you.

edit: Sort of difficult to follow that overall logic when there is a DELETE FROM statement preceding the INSERT INTO + VALUES statement, where the DELETE FROM statement relies on us knowing what the correct ID should be.

edit 2: According to the logic that the game_tele table should pick the ID automatically (auto increment), it seems that it would be more correct to delete by all the other values, which are added in the INSERT INTO statement.

edit 3: Logic loopback issue: if the DELETE FROM statement should delete by all the other values position_x, position_y, position_z, orientation, map, name, it would not be able to remove incorrect rows for that name. Maybe delete by name & map instead?

[illfated]

Sorry if I offended you, that was not intended. I was simply "thinking out loud" what the correct details in the SQL query should be.

[Aokromes]

The ID is AutoGenerated by the GameTele Table itself it should always be blank to let the database choose the correct number.

never trust autogenerated, people may have reused the id. because that the delete by id is mandatory.

[illfated]

never trust autogenerated, people may have reused the id.

Very well. So the adjustment suggestion I posted should be the preferred one, no matter if it is for 3.3.5 or master?

-- New Player Experience - Exile's Reach
DELETE FROM `game_tele` WHERE `id`= 1683 AND `map`= 2175;
INSERT INTO `game_tele` (`id`, `position_x`, `position_y`, `position_z`, `orientation`, `map`, `name`) VALUES
(1683, 459.758179, -2620.471191, 0.473076, 0.603843, 2175, 'ExilesReach');

[matanshukry]

What is this PR about? I don't remember and looks like all the details have been removed.
Is this only a PR for sql teleport location for exile's reach or did it include anything else?

[MaxtorCoder]

What is this PR about? I don't remember and looks like all the details have been removed.
Is this only a PR for sql teleport location for exile's reach or did it include anything else?

Just teleport. He was butthurt so removed PR Title and Description.

[matanshukry]

Checked the coordinates and they're not correct though; they're inside the ground.
If we want to use the same position with different height:

-- New Player Experience - Exile's Reach
DELETE FROM `game_tele` WHERE `id`= 1683 AND `map`= 2175;
INSERT INTO `game_tele` (`id`, `position_x`, `position_y`, `position_z`, `orientation`, `map`, `name`) VALUES
(1683, 459.758179, -2620.471191, 181.936, 0.603843, 2175, 'ExilesReach');

Although it's still on the steep of an hill; I'm not too familiar with the area, but a position like this which is more to the center in a more open ground would probably be a bit better:

-- New Player Experience - Exile's Reach
DELETE FROM `game_tele` WHERE `id`= 1683 AND `map`= 2175;
INSERT INTO `game_tele` (`id`, `position_x`, `position_y`, `position_z`, `orientation`, `map`, `name`) VALUES
(1683, 216.421, -2377.017, 82.530, 1.364, 2175, 'ExilesReach');

Either way we should merge it and close this issue.

[MaxtorCoder]

Would be better to just have it at the start after ship, not somewhere random.

[matanshukry]

Agreed:

-- New Player Experience - Exile's Reach
DELETE FROM `game_tele` WHERE `id`= 1689 AND `map`= 2175;
INSERT INTO `game_tele` (`id`, `position_x`, `position_y`, `position_z`, `orientation`, `map`, `name`) VALUES
(1689, -484.445, -2618.382, 4.012, 6.155, 2175, 'ExilesReach');

.go xyz -484.445 -2618.382 4.012 2175

p.s.
Also edited the ID to reflect actual higher non-used id