Trinitycore: Sindragosa's Ice Tomb remains on player and won't take damage after relogging back

[ckegg]

Description:
Sindragosa in Icecrown Citadel, once it casts Ice Tomb on a player, logout or disconnect the player and let the team wipe to stop the engagement, log the player back and Ice Tomb stays on player. At this point, player will not affect any damage from Sindragosa and this player can heal other players.

Expected behaviour:
Ice Tomb aura gets clear out from player when logged off/disconnected

Steps to reproduce the problem:

1. .go creature id 36612
2. Set instance boss state DONE from 0 all the way to 10: .instance setbossstate 0 3 to .instance setbossstate 10 3
3. Use teleport and go to Sindragosas' lair
4. Kill creeps and both Spinestalker and Rimefang to bring down Sindragosa
5. Bring in a second character
6. .cheat god on both character
7. Engage Sindragosa and wait until it takes off and ice Tomb on one of the char
8. Logout out or disconnect the one get Ice Tomb
9. Wipe the group to clear the engagement, or .die yourself
10. Log back the disconnected char, Ice Tomb remains on the player (while logging back in, .cheat god is no longer applied)
11. Use the character that has no Ice Tomb to engage Sindragosa, the character with Ice Tomb will not take any damage from Sindragosa. As long as this char is not attacking Sindragosa, it can assist other players such as healing

Video explains better: https://mega.nz/file/8WAkhb5D#LQ8P7spfwswx3YZv2EOA2uYNqKRrgiBmBcolQ7osWOM
Jump to 0:55 if you can't wait the video

Branch(es):
3.3.5

TC rev. hash/commit:
commit# cc98f68ac7fa

Operating system:
debian 10.4

[ckegg]

Just want to add that once players have Ice Tomb stays on them, they don't get hurt from now on, meaning that you can go Lich King, or any other bosses without getting damage.

[illfated]

Sounds like an unexpected exploit to me, if the ice tomb stays with you forever as a permanent "bubble".

[Rushor]

Seems like a linked aura is not removed correctly. Will check tomorrow

[Rushor]

this is the aura SPELL_ICE_TOMB_UNTARGETABLE

[Rushor]

possible fix:

diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp
index fc1147c5e5..ac8c05fd7f 100644
--- a/src/server/game/Spells/Auras/SpellAuras.cpp
+++ b/src/server/game/Spells/Auras/SpellAuras.cpp
@@ -1165,6 +1165,7 @@ bool Aura::CanBeSaved() const
         case 37025: // Water, Coilfang Raid
         case 36444: // Water, Lake Wintergrasp
         case 28801: // Slime, Naxxramas
+        case 69700: // Ice Tomb
             return false;
     }

[illfated]

Looks interesting. Waiting for feedback from the TC coders on that suggestion.

[ccrs]

@Keader since you have proficiency on this, could you debug the aura removal on player logout?

[Jildor]

This happens after this commit: https://github.com/TrinityCore/TrinityCore/commit/54e841888621ce2ea6fbfde2f86842ec088cd575
after that, all area auras with caster != owner can't be saved.

ID - 70157 Ice Tomb
=================================================
Effect 0: Id 2 (SPELL_EFFECT_SCHOOL_DAMAGE)
BasePoints = 15600 to 16401
Targets (53, 16) (TARGET_DEST_TARGET_ENEMY, TARGET_UNIT_DEST_AREA_ENEMY)
Radius (Id 13) 10,00

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 0
Targets (53, 16) (TARGET_DEST_TARGET_ENEMY, TARGET_UNIT_DEST_AREA_ENEMY)
Aura Id 12 (SPELL_AURA_MOD_STUN), value = 0, misc = 0 (0), miscB = 0, periodic = 0
Radius (Id 13) 10,00

Effect 2: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 0
Targets (53, 16) (TARGET_DEST_TARGET_ENEMY, TARGET_UNIT_DEST_AREA_ENEMY)
Aura Id 23 (SPELL_AURA_PERIODIC_TRIGGER_SPELL), value = 0, misc = 0 (0), miscB = 0, periodic = 1000
Radius (Id 13) 10,00

spell 70157 (spell_sindragosa_ice_tomb_trap) has aura area target, so when player logout, loses aura, I think player should keep aura when logout, so when player login again, would keep 70157 (stun and resummon ice tomb npc) and 69700 (ice tomb unattackable effect)

Also that commit causes problems with raid buffs, by example if you buff raid and/or pets, when you logout player or by example you have a pet and you mount and dismount, pet or logout player loses raid buffs because can't be saved.

in my opinion that @ariel- commit is wrong, I don't know if this area aura check should be needed for avoid crashes or can be removed.