Trinitycore: NPC: Bloodmage Lynnore displaying incorrect quest status icon

[TQPS]

Description:

Bloodmage Lynnore in Blasted Lands is showing an incorrect quest completion flag when 1 quest is available and 1 is in progress and not ready for turn-in.
https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?npc=7506

Expected behaviour:

NPC should be showing (in this case) quest available icon.

Steps to reproduce the problem:

1. Go to Bloodmage Lynnore
2. Take both quests - The Basilisk's Bite and Vulture's Vigor
   a) https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?quest=2601
   b) https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?quest=2603
3. Complete The Basilisk's Bite only and turn quest in
4. Icon will now display quest ready for turn-in flag - even though it's not

Branch(es):

3.3.5

TC rev. hash/commit:

TrinityCore rev. cc8287927b9c 2020-11-18 20:09:34 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static)

Operating system: Windows 7 64bit

[illfated]

Hmm. At first, I thought maybe this had something to do with the mess you get from shared quest item requirements, but this is more about the completed quest not showing up at all in the gossip (from my point of view, at least). Glad you posted this, I can easily go check this out myself, since my character just made it into the upper half of level bracket 50-60.

[illfated]

Oh well. I can't replicate your findings by doing only what you wrote in the text. The quest completed correctly for me:

Details

I do not see the quest "Infallible Mind" offered yet (not sure why, maybe it is because the quest "The Basilisk's Bite" has not been rewarded yet).

By the way, it looks like you have taken one or more other quests requiring the same type of quest items (Basilisk Brain required for the quest "A Boar's Vitality"), which increases the need for more reproduction details this issue.

TC> server debug
TrinityCore rev. cc8287927b9c 2020-11-18 20:09:34 +0100 (3.3.5 branch) (Win64, Release, Static)

Using SSL version: OpenSSL 1.1.1g  21 Apr 2020 (library: OpenSSL 1.1.1g  21 Apr 2020)
Using Boost version: 1.73.0
Using MySQL version: 50731
Using CMake version: 3.18.3
Compiled on: Windows 10.0.19041
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 251987687 bytes
vmaps directory located in ./vmaps. Total size: 658130721 bytes
mmaps directory located in ./mmaps. Total size: 1962379500 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.20111
TC> _

[illfated]

I am now trying to compile a list of the same quest items you have in your inventory for the following quests:

• https://classic.wowhead.com/quest=2583/a-boars-vitality
• https://classic.wowhead.com/quest=2603/vultures-vigor

I believe these parts (quests taken, quest items looted) are necessary to complete your list of requirements to reproduce your issue.

BTW, I just turned in A Boar's Vitality and the quest Infallible Mind immediately became available to me, so that detail is not an issue at all.

[illfated]

OK, so I am able to reproduce your issue to some extent:

Note: in addition to your description above, I took the extra quest "A Boar's Vitality" (ID 2583) listed in your image to get the issue to show up. I also checked that the quest marker above Bloodmage Lynnore did not change into a yellow ❔ before I had collected 8 or 9 Vulture Gizzards, so _the quest item count_ is the real conundrum here.

[TQPS]

Great pickup.

[illfated]

Also note: After dropping the quest and retaking it, the quest status shows up correctly. (same rev. hash, https://github.com/TrinityCore/TrinityCore/commit/cc8287927b9c9f0bf20143972fd4d3c338bff688)

[dr-j]

See https://github.com/TrinityCore/TrinityCore/issues/25603 has I used these quests as an example in a comment I made there

Think its because when you have more than one quest in log and you loot items the count for all quests which require item update simultaneously and when when you turn in a quest does not update quest status of other quests which needed same item when one was turned in or quests are still marked as complete even though you no longer have all required items due to previous turn in

[illfated]

Good point. Still feels like the act of sorting bag contents can affect that issue even for the first quest hand-in.