Trinitycore: Core/Quests: Sometimes 'Complete Quest' button can't be properly clicked

[LEO33SoFo]

Description:

Completing the quest A Taste of Flame (4022) does not prompt for the follow-up quest A Taste of Flame (4024), the window stays stuck, the _Complete Quest_ button can't be properly clicked.
The text seems wrong too. The turn-in window text should not have the line _Show Cyrus Therepentous proof of your worth._ according to Wowpedia.

This issue is referenced here too: #22432

Expected behaviour:

If you have completed the Divine Retribution quest line and you have the Black Dragonflight Molt, _Cyrus Therepentous_ should offer A Taste of Flame (4022) and then allow you to accept A Taste of Flame (4024).

Steps to reproduce the problem:

1. .quest add 4022
2. .additem 10575
3. .go creature id 9459
4. Try to turn in the quest.

Branch(es):

3.3.5

TC rev. hash/commit:

43986954fddc05e0fe1f225b0cf38a7b01f775bb

Operating system: Windows 7 Enterprise 64bit

[Carbenium]

If you don't use additem but actually let the NPC summon the the dragon and loot it, the quest works just fine.

[LEO33SoFo]

I am playing the quests without GM commands, and encountered the quest bug.

I only added the commands as per Steps to reproduce the problem bug post instruction.

Notice that the alternative A Taste of Flame (4023) works fine even with GM commands.

[LEO33SoFo]

@Carbenium No dragon was summoned during my gameplay. You are mistaking the quest for the alternative A Taste of Flame (4023). Please read thoroughly the problem and test it yourself, including my line "The text seems wrong too…".

[offl]

The text seems wrong too. The turn-in window text should not have the line Show Cyrus Therepentous proof of your worth.

Isn't the turn-in window shown in your screenshot? There's no such text
Anyway I can't see any problem in DB-side, all texts are fine. Didn't yet tried in game

[LEO33SoFo]

@offl I just edited my main post, please check the video to see the problem.

P.S: All my bug posts here in _Github_ have been encountered during the normal gameplay, without GM commands.

[illfated]

From my experience, you get an unresponsive quest reward gossip window (you should be able to close it with the [X] button, though) whenever you are supposed to automatically continue to the next quest, but the next quest in line is already completed. This can also happen if the DB quest chaining is incorrect or broken. Not sure what is the case here.

[LEO33SoFo]

@illfated In my case, the next quest in line A Taste of Flame (4024) has never been started and completed. The NPC _Cyrus Therepentous_ also does not give this quest, even though A Taste of Flame (4022) has been completed and rewarded.
Also the description of the quest in the window is wrong according to Wowpedia, the correct one does not have the sentences _You seek out the Flight? Present to me proof of your worth, mortal._, these sentences should be correct only to A Taste of Flame (4023) if I am not mistaken.

[illfated]

Very well, then the conclusion must be that the quest chaining order is incorrect in the TC DB.

[dr-j]

well https://www.wowhead.com/quest=4023/a-taste-of-flame is current prequest of quest 4024

but from wowhead comments for this quest:-

By adashiel (277,561 – 17·95·919) on 2008/07/25 (Patch 2.4.3)
To clarify, this version of "A Taste of Flame" is offered to those who have not completed the quest line of Kalaran Windblade in the Searing Gorge. If you've done all those quests and still have the Black Dragonflight Molt you earned after completing Trinkets..., you'll receive the alternate version of A Taste of Flame instead.

[illfated]

Thank you for clarifying. So... does this mean that this quest appears incorrectly for the player (I have not had time to test this myself), or is this a random glitch for only the OP?

[Carbenium]

This issue at least doesn't seems to be related to the recent packet ports.
With 01c7663b and 87211d9f reverted, the issue is still reproducible.

[illfated]

Good job, thank you for checking and confirming.

[Faq]

was not able to reproduce on bf7efe3ca040f2dcd965e382ff863f0a924af23f

1.) Started with this gob https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?object=149502#starts for some reason it dint gave q 3481 so added it with command.
2.) .go c id 9459 and got from him q 4022
3.) killed dragon, looted item and delivered it and took next q 4024 and didn't had issue what is on video with button "Complete quest".

[offl]

I can't reproduce both issues in 5055a1f8d552

[genion18]

You have started Quest 4023 thit .go c id 9459. The alternative quest.

to reporduce from Poster:

.go c id 9459
.quest add 4022

[offl]

.go c id 9459
.quest add 4022
.quest c 4022
turn in

Yeah, the complete button isn't clickable with these steps to reproduce. But the thing is the bug occurs only when commands are used.
Before 4022 you have to complete quest 3481 and if you do, everything will work just fine. But if you just add the quest by command and try to turn it in, the complete button will be not clickable.

4023 is available without any previous quests, works always correctly.

We need to find at least one example of unclickable complete button by obtaining and completing the quest normally without commands.

[Faq]

Parse log compare where Stuck on Quest Complete vs No stuck

So it stuck to the "Quest Complete" because there was Amount of Quest gossips: 1, but should be 2. In simple terms, no next quest to load. Check left side line 168
Reason might be SMSG_COMPRESSED_UPDATE_OBJECT on line 126 not receiving [0] Block Value 24: 8026

bf7efe3ca040f2dcd965e382ff863f0a924af23f

[genion18]

Quest_template_addon Id 4024 says PrevQuestID is 4023 so is from 4022, 4024 Blocked.
When PrevQuestID 4022 is 4024 for this OPen but for Quest 4023 to 4024 blocked.

('4024', '0', '0', '0', '4023', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '0', '1', '0');

[gygyti]

I want to add that:
this happens (complete button is inactive) with quests that must have some item to complete

[gygyti]

this is due to the change in the number of items for the quest.

for example, you need 10 items, but you have collected 12. If you remove 2 items, the quest cannot be completed.

here is another example,
if for two quests you need the same item, then when you pass one of the quest, it is impossible to complete the second.

and one more example,
if you take the necessary item for the quest and put it in the bank (or give it to an ally), and then return it to yourself, then the quest cannot be completed