Trinitycore: SQL Error

[LordWaycrest]

Description:

When a player tries to login with an incorrect password it normally logs it to the logs_ip_actions table in the authserver databse (if enabled), but since Pull Request #24453 was implemented, the query is trying to insert the ip into the realm_id column which is resulting in this SQL error:

SQL(p): INSERT INTO logs_ip_actions (account_id, character_guid, realm_id, type, ip, systemnote, unixtime, time) VALUES (2, 0, '127.0.0.1', 1, 'Login to WoW Failed - Incorrect Password', 0, unix_timestamp(NOW()), NOW())
Unhandled MySQL errno 1265. Unexpected behaviour possible.

This is also causing the entry to not be created in the DB, It seems to only be affecting wrong password logging since account logins, char logins/logouts seem to be logging just fine with no error.

Current behaviour:

What I put above ^

Expected behaviour:

It should insert data into the correct columns in logs_ip_actions

Steps to reproduce the problem:

1. Enable wrong password logging in authserver.conf
2. Try logging in with an incorrect password
3. Check authserver logs and you should see the error

Branch(es):

3.3.5

TC rev. hash/commit:

TrinityCore rev. 740afc71358c 2020-04-21 22:22:31 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (authserver)

Operating system:

Windows Server 2016 Standard

[ForesterDev]

I've posted a PR with fix. Can you test it in-game?

[LordWaycrest]

I've posted a PR with fix. Can you test it in-game?

Yes, I'll fire up a PTR right now.

[LordWaycrest]

I've posted a PR with fix. Can you test it in-game?

Hi, apologises for the delay, I can confirm it works. :-)

[LordWaycrest]

Pull Request #24487 has been merged, closing.