Trinitycore: Creating a Demon Hunter Crashes Worldserver

[xXBentRealityXx]

Description:

The server crashes when you try to make a Demon Hunter and click the "Finish" button on the character creation screen.

Current behaviour:

Creating a Demon Hunter crashes worldserver.
Crashlog: https://gist.github.com/xXBentRealityXx/39a80929c8dcaa42e7e7d697cc1fe64a

Expected behaviour:

Creating a Demon Hunter should not crash worldserver.

Steps to reproduce the problem:

1. Make a Demon Hunter.

Branch(es):

master

TC rev. hash/commit:

334cc3e23275

Operating system: Windows 10.0.18362

[xXBentRealityXx]

Seems to be related to 9aa5f625a617

[Ovahlord]

It's not. If the crashlog tells the truth it's either a player nullptr crash or a item nullptr crash. The lines that the crashlog provides are not related to skills in this case. I guess that's also what crashes my other skill PR. Something got screwed up here and it's not my fault

[MaxtorCoder]

It indeed is related to Player::CanUseItem debug that function to see where it crashes exactly.

[RaphtaliaYukii]

@MaxtorCoder I debug whole function and isn't the problem, the crashlog show it as last call to GetTeam() inside CanUseItem() but it's a false positive, no null pointers or values inside and the returned values are correct.

I still debugging whole process, it's related with start items handling, because if you comment the item creation process with CharStartOutfit.db2 you can enter in the world without any error or crash.

@xXBentRealityXx are close, I dont blame the commit of @Ovahlord but the item handling seems fine on my research, the pending parts of my debug are other things called on item creation like spells, enchantments, skills...

If I found it I summit the PR, for now I'm still searching the real fault.

[xXBentRealityXx]

It's not. If the crashlog tells the truth it's either a player nullptr crash or a item nullptr crash. The lines that the crashlog provides are not related to skills in this case. I guess that's also what crashes my other skill PR. Something got screwed up here and it's not my fault

Oddly enough when I reverted the commit I spoke of I was able to make a demon hunter. Maybe it was just a fluke though

[RaphtaliaYukii]

@xXBentRealityXx are fine, after revert 9aa5f62 the worldserver didn't crash and I can create a Demon Hunter without problems, so I confirm too that this commit causes the problem

[Shauren]

I will take a look at this later today, if reproducing it is 100% reliable by always creating a demon hunter then I won't need any more information here

[RaphtaliaYukii]

@Shauren I understand your commit and seems reasonable, on character create the characters isn't in world, then GetPlayer() always gona return null, but I didnt see the relation with 9aa5f62.

[xXBentRealityXx]

It is fixed, also fixed characters not equipping their start outfit and not being able to make allied races. Thanks Shauren!

[Shauren]

@RaphtaliaYukii there was never any relation to skills in the first place...

[RaphtaliaYukii]

@Shauren But reverting 9aa5f62 have the same effect that this fix, seems interesting

[Ovahlord]

Pretty sure that's just a bad coincidence. Reading crashlogs helps