Trinitycore: Update scripts to current standards

Created on 2 Jan 2020 · 13Comments · Source: TrinityCore/TrinityCore

Description:

We want to get rid of those ancient SD2 scripts. We will provide sniffs to whoever is inclined to improve them.

Please make one PR for each boss, not full instances. If you have plans to make multiple requests i suggest you to make them in a way that we can merge multiple pull requests at once.

Note:
Scripts using if Is25ManRaid() must be converted to use spelldifficulty_dbc

Expected behaviour:

Scripts are updated to current standards and checked with sniffs.

Progress

Eastern Kingdoms

Kalimdor

Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance
------------ | ------------- | ------------- | ------------- | ------------- | -------------
Dustwallow Marsh outdoor | | | | 8fa6f95d4b77e9c596df83cc825dd0156824fdaa |
Feralas outdoor | | | | 5cddcc7 |
Azuregos | | #26392 | | fe41744c7a082cf726ec63ace9f823f47d80a5a0 |

Outland

Northrend

Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance
------------ | ------------- | ------------- | ------------- | ------------- | -------------
Ahn'Kahet | Ahn'Kahet | | | |
|| Herald Volazj | #25187 | | yes |
Azjol-Nerub | Azjol-Nerub | | | |
|| Anub'Arak | #25192 | | yes |
Gundrak | Gundrak | | | |
|| Slad'ran | #25180 | | yes |
|| Drakkari Colossus | #25182 | | yes |
Violet Hold | Violet Hold | | https://github.com/TrinityCore/TrinityCore/commit/d22dcd1f6e95a85180536639723b642a8922b866 | yes |
|| Cyanigosa | https://github.com/TrinityCore/TrinityCore/pull/26371 | | 94299a3 |
Utgarde Pinnacle | Utgarde Pinnacle | | | |
|| Gortok Palehoof | https://github.com/TrinityCore/TrinityCore/pull/26370 | | ba7f11c |
Utgarde Keep | Utgarde Keep | | | |
|| Ingvar | https://github.com/TrinityCore/TrinityCore/pull/26369 | | https://github.com/TrinityCore/TrinityCore/commit/8d9f24bb18395f6af318e053677c0266d5ca1e4d | |

Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance
------------ | ------------- | ------------- | ------------- | ------------- | -------------
Icecrown Citadel | Icecrown Citadel | | | yes | yes |
|| Blood council | #25389 | | yes | |
|| Lich King | #25396 | | yes |
|| Sindragosa | #25395 | | yes |
|| Professor Putricide | #25394 | | yes |
|| Valithria Dreamwalker | #25390 | | yes |
|| Festergut | #25391 | | yes |
|| Rotface | #25392 || yes |
|| Lady Deathwhisper | #25393 || yes |
|| Blood Queen Lana'thel | https://github.com/TrinityCore/TrinityCore/pull/25434 || yes |
|| Deathbringer Saurfang | https://github.com/TrinityCore/TrinityCore/pull/25435 || yes |
|| Lord Marrowgar | https://github.com/TrinityCore/TrinityCore/pull/25436 || yes |
|| Gunship Battle | https://github.com/TrinityCore/TrinityCore/pull/25438 || yes |
|| Icecrown Citadel scripts | https://github.com/TrinityCore/TrinityCore/pull/25439/ || yes |
Vault of archavon| Vault of archavon | | | |
|| Vault of archavon | https://github.com/TrinityCore/TrinityCore/pull/26372 | | 3ece1ee | yes |
Naxxramas | Naxxramas | | | | yes |
|| Thaddius | https://github.com/TrinityCore/TrinityCore/pull/26391 | | 07fe74b2333567d0c51b22e587396ddc70da1ffb | |
|| Razuvious | https://github.com/TrinityCore/TrinityCore/pull/26389 | | 52935060ace13cb0cc8bbc87d9f1d299d20d72ea | |
|| Sapphiron | https://github.com/TrinityCore/TrinityCore/pull/26390 | | 2cbfb784e047f5711bb543de38c9760ff84b9dd7 | |
|| Noth | https://github.com/TrinityCore/TrinityCore/pull/26387 | | 7dc1d5c5a1fad174e35dabb261431969f3db686a | |
|| Patchwerk | https://github.com/TrinityCore/TrinityCore/pull/26388 | | 6f0bc11bcef90b850edb13292a20165dbbbea87a | |
|| Maexxna | https://github.com/TrinityCore/TrinityCore/pull/26386 | | cb82cded17f49c7736012f226c542c2240bbf7a4 | |
|| Heigan | https://github.com/TrinityCore/TrinityCore/pull/26383 | | d694086e95f85821f47da3475f3a9e1faa39b6ce | |
|| Kel'Thuzad | https://github.com/TrinityCore/TrinityCore/pull/26384 | | ff4d9a81ae7408a4b99bbd2d69f72ff0f9f5479f | |
|| Loatheb | https://github.com/TrinityCore/TrinityCore/pull/26385 | | fb39a3cabd8c703ae3eb5fd3b91baae60badd055 | |
|| Grobbulus | https://github.com/TrinityCore/TrinityCore/pull/26382 | | cc3ef7ea695466a3fd8f3c9aa965ae7a4908caf2 | |
|| Gluth | https://github.com/TrinityCore/TrinityCore/pull/26380 | | 44686c3c5069501e30b167be418aca4d05e42818 | |
|| Gothik | https://github.com/TrinityCore/TrinityCore/pull/26381 | | 9c72ca2b04c5595d2a637f0827eb6b2374734c70 | |
|| Four Horsemen | https://github.com/TrinityCore/TrinityCore/pull/26379 | | 7ef0de84ac7a9578fe7f89592e3019857f615422 | |
|| Faerlina | https://github.com/TrinityCore/TrinityCore/pull/26378 | | 4d82c6a1865d726bae2a77b8a1579247c7c317e2 | |
|| Anub'Rekhan | https://github.com/TrinityCore/TrinityCore/pull/26377 | | 128820372996d27afc008648bf6f75a5c10503e4 | |

Class scripts

Class | Codestyle | Merged
------|-----------|-------
Priest| |7cb9cd9
Shaman| |b1e4d93
Warrior| |5715ed0
Hunter| |11ba46d

Branch(es):

both

TC rev. hash/commit:

be65f7d

Comp-C++Script Priority-FutureFeatureRequest Sub-Instances help wanted

Source

Aokromes

👍4 👀3

Most helpful comment

@Faq Black Temple (in 3.3.5 branch) is 100% in new standards

Keader on 19 Jan 2020

👍3 ❤1

All 13 comments

Any example boss which scripted to newest standards?

Faq on 19 Jan 2020

Not 100% sure, but I assume 3.3.5/src/server/scripts/Northrend/Ulduar/Ulduar/boss_yogg_saron.cpp could be one of them, because it does not contain any /* ScriptData or SD reference lines, as well as being one of the most recently updated scripts.