Trinitycore: Summoned Guardians doing only 1 melee damage

[TerrorBringer]

Description:

I have been noticing that creatures such as https://www.wowhead.com/npc=21267/mana-beast (Sunfury Nethermancer's guardian), and even guardians spawn via quest such as https://www.wowhead.com/npc=20603/reflection-of-ya-six are only doing 1 damage on melee hit.

I searched if the same issue was already posted, but only found this one #281 which talks about overpowerd minions.

EDIT: They also hit regularly for 2 dmg and 6 on a crit.

Expected behaviour:

Summoned guardians should have a melee damage output appropriate for their level.

Branch(es):

3.3.5

TC rev. hash/commit:

https://github.com/TrinityCore/TrinityCore/commit/9f66158ae552ea8195e870703f55f0a4483745d0

Operating system: Win 10 x64

[jackpoz]

what level are you ? what level is the target ?

[TerrorBringer]

I am level 70, Mana beast is 69-70, Reflection of Agent Ya-six is 68.

[jackpoz]

could you try reverting https://github.com/TrinityCore/TrinityCore/commit/5f5d2028df70e82d5cd70837953acd059f2ac7fb and see if anything changes ?

[TerrorBringer]

I tried rev 50b2c3b34d5ffc9539e3f3954ec6b4e5f8a87efc, which came before 5f5d202, the Mana beast is hitting 60-70 dmg on armor that provides a 41% damage reduction.

[jackpoz]

@Wyrserth could you take a look at this ?

[jackpoz]

I have a local fix that I will PR in a few days.
With a level 80 character with no gear https://www.wowhead.com/npc=21267/mana-beast does:

• 3 damage with current TC
• 105 damage with a patch
• 60 damage with another patch

The summoner does 250 damage. Which one seems more correct ?

[Killyana]

105 according to videos. https://youtu.be/hE_xK-qpas8

[jackpoz]

I opened a PR for this, please test it https://github.com/TrinityCore/TrinityCore/pull/23840

[Killyana]

The damage looks fine

[jackpoz]

is there any other guardian to test ?

• did I cause some guardians to do too much damage ?
• are there still guardians with too little damage ?

or should we merge the PR ?

[Jinnaix]

I had a report a while ago that Sharam, summoned by this item only hits for 2 damage. Maybe Killyana can check this one too.

[Killyana]

The damage of Sharam looks correct and scales properly according to the level.
I cannot find a case where the damage is too low or high.

[Aokromes]

b3b8ec8