Trinitycore: [Crash] _defaultGenerator->Deactivate #

[HAANAAE]

Description: warning: Not specified

Crash log
https://gist.github.com/HAANAAE/704f017e160faa782256d45bf01ae1c1

Branch(es): 3.3.5
TC rev. hash/commit: b33934f
Operating system: debian

[Shauren]

Character loads with a confuse aura (rogue blind?)
MotionMaster is not initialized until after LoadFromDB finishes

[ccrs]

Invalidate the aura while loading?
Prevent the aura from saving?
Make MotionMaster initialize before LoadFromDB?

[Shauren]

Delay MoveConfuse until after adding to world? First two options would give you incorrect behavior

[ccrs]

makes sense, queue everything and signal MotionMaster, neat
not too difficult to implement after the rework hehe

[jackpoz]

@ccrs could you check this issue when you have time ?

[jackpoz]

Crash reproduced

• .cast 9992 https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?spell=9992
• logout as fast as possible
• login as fast as possible

As the spell has a 9 seconds duration, one has to log back in before the spell expires to trigger the crash

[jackpoz]

Fixed by https://github.com/TrinityCore/TrinityCore/commit/9941b4c2edcf63e6e521249a6660b590f23cd08d

[ccrs]

MotionMaster modifications have been delayed till just after AddToWorld

new crashlog: https://github.com/TrinityCore/TrinityCore/files/3756374/unknown_worldserver.exe_.22-10_16-26-15.txt

[jackpoz]

MoveChase is still added before the default one is added as both are added to delayed actions queue, first MoveChase and then Initialize

[ccrs]

unsigned int BaseUnitState = 0x800 --> UNIT_STATE_CONFUSED --> MotionMaster::MoveConfused() 😄

but damn.. this is annoying
if we just protect _defaultGenerator->Deactivate(_owner); against incorrect access we will bump into:

• MoveConfused --> Initialize --> Clear --> MoveConfused is gone

[ccrs]

transform delayedActions into priority queue? 😨

ignore all Initialize calls done during "initializing" --> always perform one Initialize call before handling the queue --> handle the queue ??? 😨

[jackpoz]

Creatures in formations call MoveIdle() instead of Initialize() which make it harder to know when the initialization has been completed, see https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Entities/Creature/Creature.cpp#L998

[jackpoz]

but damn.. this is annoying

yes xD

[jackpoz]

https://github.com/TrinityCore/TrinityCore/commit/c9c6871659bf2be52b4656bc641df5211fcb928f