Trinitycore: WSG Flag while mounted

[Duratans]

Description:

Warsong flags can be picked up while mounted, to reproduce it needs to be done super fast.
If you click on the Flag millisecond before your Mount Cast Bar expires and boom! you are mounted and with a flag on your back!

Expected behavior: Players are not supposed to achieve this, cannot pick up flag while mounted

Steps to reproduce the problem:

• Pick up a flag and walk outside,
• Drop the Flag
• Cast any mount spell (I tried over 20 mounts, all work)
• Millisecond before your Mount Cast Bar expires click on the flag
• Sometimes it won't work the first time cause you have to try it few times before you get a hang of it.

Branch(es): 3.3.5

TC rev. hash/commit: 9ab05e2

[Killyana]

I cannot reproduce it.
It's supposed to be fixed with https://github.com/TrinityCore/TrinityCore/commit/98236dfa8846aeea2643deaab5ca86b803e3aee7 an for me it works fine.

[jackpoz]

Are you using any custom change ?

[Keader]

Old issue about it: #19979

[Jildor]

Where is your old superhackfix for it, @Keader ? with autokill functionality 😄

[Duratans]

Its not easy to reproduce. I myself tried 10 times before i was able to reproduce.
No custom changes.
However the bug is still exploitable

[Killyana]

I tried for 15 min and impossible to reproduce, are you testing in a locale server? maybe some latency is required to reproduce it.

[Keader]

@Jildor me? hackfix? nevah !
i think that i lost it...
Btw, i remember when ariel send a commit fixing it, i tested and was working...
Maybe someone reverted his fix?

[Killyana]

Not reverted, and works fine

[Duratans]

Im testing on a live test server. Using absolutely nothing custom. We succesfully reproduced the bug in WSG using 10 different mounts. 2 times out of 10 you can pick up the flag milliseconds before your mount casting bar is completed. The result you can carry the flag and use your abbilites.

Impossible to reproduce on a local server. I can only reproduce this bug on a live server 50 to 100 MS Latency.

[Keader]

Yeah, latency is needed

[illfated]

@Illuminati2739 : I may have misunderstood what you wrote, but when you said

Im testing on a live test server. [ ... ]

, did you mean a TC source based server or a retail server?
(Just wanted to clarify if this is a retail bug or TC bug.)

[Duratans]

@illfated I mean a server that is live with people on it. Ofc a TC server :)

[Killyana]

When this happen the mount will not be displayed but the mount speed is applied to the character, also the player is able to cast spells: