Trinitycore: ChatStrictLinkChecking with Colors

[ghost]

Description: I want to make a pvp fun server and need to creat custom Colored items, but in the new version Trinitycore Could not link colored items!

error log:

Player Hiroshi (GUID: 10) sent a message with an invalid link:
|cffff8000|Hitem:10888:0:0:0:0:0:0:0:80|h[|cffCCCCCCtest item]|h|r

---

This is a problem for: items and creatures in color, Can not linked! %t
ChatStrictLinkChecking.Severity = !
There are no worldserver.conf to fix

I know this is not blizzlike But it's needed for fun pvp or more... modes...if want use with trinitycore

Branch(es): 3.3.5
TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/58c5dfac1d8d314b9243fde52466b3c933fb7d7f
Os: windows 2016 server

[jackpoz]

It would be nice to add back a config to disable the link checks

[Shauren]

If you want to open your server to idiots sending malformed links that crash the game of everyone who sees their chat then go ahead but I don't agree with this "feature"

[ghost]

I know But this is a need, add a line on worldserver.conf for disable link checks!

fun/pvp/custom/ servers need this to use with trinitycore
Or
Killing TrinityCore for Custom Mod Servers....

---

Blizzlike Servers:
ChatStrictLinkChecking.Severity = 1 => enable

Custom or Fun Servers:
ChatStrictLinkChecking.Severity = 0 => disable

[Aokromes]

no, it's not a need.

[ghost]

I need.
Confirm

[shadowbin]

confirm

[SoyTorete]

Confirm what? If you want something that is unnecessary / not useful for TrinityCore Project, create it yourself and if you think it is interesting for everyone else, make a pull request.

[tatense]

Like the old version, can add something to fix, disable the link checks.
(worldserver.conf)
I do not think it useful, but it's needed

[TheWinchesters]

I do not think that this is a objective conversation.
If you have a server that has reached a level of 'customization' where the TrinityCore changes are not compatible, then you may need to develop your own 'fixes' for these types of problems.

[jackpoz]

btw @Hir0shi you reported https://github.com/TrinityCore/TrinityCore/issues/22399 and the current code was built exactly to deal with that issue.
If we add back an option to fully disable the link checking, you will have https://github.com/TrinityCore/TrinityCore/issues/22399 again.
If you have time and resources available to change https://github.com/TrinityCore/TrinityCore/commit/f27284594b18000a1c098262728fb19fdc63fc6c so that custom colors are supported too, we might consider adding that code to TC.

[ghost]

My Love @Jackpoz

Can create a part for disable the link color checks!? Requirements colors

example color:

GREY "|cff888888"
WHITE "|cffffffff"
SUBWHITE "|cffbbbbbb"
MAGENTA "|cffff00ff"
YELLOW "|cffffff00"
CYAN "|cff00ffff"
LIGHTRED "|cffff6060"
LIGHTBLUE "|cff00ccff"
BLUE "|cff0000ff"
GREEN "|cff00ff00"
RED "|cffff0000"
GOLD "|cffffcc00"
ALICEBLUE"|cFFF0F8FF"
ANTIQUEWHITE"|cFFFAEBD7"
AQUA "|cFF00FFFF"
AQUAMARINE "|cFF7FFFD4"
AZURE "|cFFF0FFFF"
BEIGE "|cFFF5F5DC"
BISQUE"|cFFFFE4C4"
BLACK "|cFF000000"
BLANCHEDALMOND "|cFFFFEBCD"
BLUE "|cFF0000FF"
BLUEVIOLET "|cFF8A2BE2"
BROWN "|cFFA52A2A"
BURLYWOOD"|cFFDEB887"
CADETBLUE"|cFF5F9EA0"
CHARTREUSE "|cFF7FFF00"
CHOCOLATE"|cFFD2691E"
CORAL "|cFFFF7F50"
CORNFLOWERBLUE "|cFF6495ED"
CORNSILK "|cFFFFF8DC"
CRIMSON "|cFFDC143C"
CYAN "|cFF00FFFF"
DARKBLUE "|cFF00008B"
DARKCYAN "|cFF008B8B"
DARKGOLDENROD "|cFFB8860B"
DARKGRAY "|cFFA9A9A9"
DARKGREEN"|cFF006400"
DARKKHAKI"|cFFBDB76B"
DARKMAGENTA "|cFF8B008B"
DARKOLIVEGREEN "|cFF556B2F"
DARKORANGE "|cFFFF8C00"
DARKBLUESKY "|cffff8000"
DARKORCHID "|cFF9932CC"
DARKRED "|cFF8B0000"
DARKSALMON "|cFFE9967A"
DARKSEAGREEN"|cFF8FBC8B"
DARKSLATEBLUE "|cFF483D8B"
DARKSLATEGRAY "|cFF2F4F4F"
DARKTURQUOISE "|cFF00CED1"
DARKVIOLET "|cFF9400D3"
DEEPPINK "|cFFFF1493"
DEEPSKYBLUE "|cFF00BFFF"
DIMGRAY "|cFF696969"
DODGERBLUE "|cFF1E90FF"
FIREBRICK"|cFFB22222"
FLORALWHITE "|cFFFFFAF0"
FORESTGREEN "|cFF228B22"
FUCHSIA "|cFFFF00FF"
GAINSBORO"|cFFDCDCDC"
GHOSTWHITE "|cFFF8F8FF"
GOLD "|cFFFFD700"
GOLDENROD"|cFFDAA520"
GRAY "|cFF808080"
GREEN "|cFF008000"
GREENYELLOW "|cFFADFF2F"
HONEYDEW "|cFFF0FFF0"
HOTPINK "|cFFFF69B4"
INDIANRED"|cFFCD5C5C"
INDIGO"|cFF4B0082"
IVORY "|cFFFFFFF0"
KHAKI "|cFFF0E68C"
LAVENDER "|cFFE6E6FA"
LAVENDERBLUSH "|cFFFFF0F5"
LAWNGREEN"|cFF7CFC00"
LEMONCHIFFON"|cFFFFFACD"
LIGHTBLUE"|cFFADD8E6"
LIGHTCORAL "|cFFF08080"
LIGHTCYAN"|cFFE0FFFF"
LIGHTGRAY"|cFFD3D3D3"
LIGHTGREEN "|cFF90EE90"
LIGHTPINK"|cFFFFB6C1"
LIGHTRED "|cFFFF6060"
LIGHTSALMON "|cFFFFA07A"
LIGHTSEAGREEN "|cFF20B2AA"
LIGHTSKYBLUE"|cFF87CEFA"
LIGHTSLATEGRAY "|cFF778899"
LIGHTSTEELBLUE "|cFFB0C4DE"
LIGHTYELLOW "|cFFFFFFE0"
LIME "|cFF00FF00"
LIMEGREEN"|cFF32CD32"
LINEN "|cFFFAF0E6"
MAGENTA "|cFFFF00FF"
MAROON"|cFF800000"
MEDIUMAQUAMARINE "|cFF66CDAA"
MEDIUMBLUE "|cFF0000CD"
MEDIUMORCHID"|cFFBA55D3"
MEDIUMPURPLE"|cFF9370DB"
MEDIUMSEAGREEN "|cFF3CB371"
MEDIUMSLATEBLUE"|cFF7B68EE"
MEDIUMSPRINGGREEN "|cFF00FA9A"
MEDIUMTURQUOISE"|cFF48D1CC"
MEDIUMVIOLETRED"|cFFC71585"
MIDNIGHTBLUE"|cFF191970"
MINTCREAM"|cFFF5FFFA"
MISTYROSE"|cFFFFE4E1"
MOCCASIN "|cFFFFE4B5"
NAVAJOWHITE "|cFFFFDEAD"
NAVY "|cFF000080"
OLDLACE "|cFFFDF5E6"
OLIVE "|cFF808000"
OLIVEDRAB"|cFF6B8E23"
ORANGE"|cFFFFA500"
ORANGERED"|cFFFF4500"
ORCHID"|cFFDA70D6"
PALEGOLDENROD "|cFFEEE8AA"
PALEGREEN"|cFF98FB98"
PALETURQUOISE "|cFFAFEEEE"
PALEVIOLETRED "|cFFDB7093"
PAPAYAWHIP "|cFFFFEFD5"
PEACHPUFF"|cFFFFDAB9"
PERU "|cFFCD853F"
PINK "|cFFFFC0CB"
PLUM "|cFFDDA0DD"
POWDERBLUE "|cFFB0E0E6"
PURPLE"|cFF800080"
RED"|cFFFF0000"
ROSYBROWN"|cFFBC8F8F"
ROYALBLUE"|cFF4169E1"
SADDLEBROWN "|cFF8B4513"
SALMON"|cFFFA8072"
SANDYBROWN "|cFFF4A460"
SEAGREEN "|cFF2E8B57"
SEASHELL "|cFFFFF5EE"
SIENNA"|cFFA0522D"
SILVER"|cFFC0C0C0"
SKYBLUE "|cFF87CEEB"
SLATEBLUE"|cFF6A5ACD"
SLATEGRAY"|cFF708090"
SNOW "|cFFFFFAFA"
SPRINGGREEN "|cFF00FF7F"
STEELBLUE"|cFF4682B4"
TAN"|cFFD2B48C"
TEAL "|cFF008080"
THISTLE "|cFFD8BFD8"
TOMATO"|cFFFF6347"
TRANSPARENT "|c00FFFFFF"
TURQUOISE"|cFF40E0D0"
VIOLET"|cFFEE82EE"
WHEAT "|cFFF5DEB3"
WHITE "|cFFFFFFFF"
WHITESMOKE "|cFFF5F5F5"
YELLOW"|cFFFFFF00"
YELLOWGREEN "|cFF9ACD32"

[jackpoz]

btw @Hir0shi using the test case at https://github.com/TrinityCore/TrinityCore/issues/22781#issuecomment-437568950 the link looks like this

Is this how it's supposed to look ? with the first [ white and the rest red ?

[ghost]

Hi , Super Man

Yes It is true, your item custom but
shift + link item custom don't work!
i can't link item

ChatStrictLinkChecking.CustomLinks = 1
using with https://github.com/TrinityCore/TrinityCore/pull/23054/commits/6d195085adbbbdd4651ffe35818885316bc5dace

[jackpoz]

Ah yeah, you need to write the colour in lowercase letters, FF will not work, use ff. You might have to clear the WoW client cache too.

[ghost]

@jackpoz

delete Cache and set to ff => lowercase letters!
shift + link item , Worked.

Just with icon achievements, not work

Player Hiroshi (GUID: 10) sent a message with an invalid link: |cffffff00|Hquest:10888:80|h[|TInterface/ICONS/achievement_worldevent_valentine:20:20|t|cffcc3300test item]|h|r

[jackpoz]

well the point of the PR is to show how to allow some customizations without (hopefully) adding back any exploit.
if you have other customization cases, you could change the code to support those and then share it.

[illfated]

btw Hir0shi using the test case at #22781 (comment) the link looks like this

Is this how it's supposed to look ? with the first [ white and the rest red ?

Looks like a case of misplaced pipe character (after instead of before the first square bracket).

[jackpoz]

Please check https://github.com/TrinityCore/TrinityCoreCustomChanges/tree/3.3.5-custom_links for a proof-of-concept about how to implement custom links while (hopefully) keeping it safe from exploits crashing the client.

Closing this issue as it requires changes that will not be merged into official TrinityCore repo but anyone is free to merge the branch above (and improve it adding new customization cases, opening a PR on that repo)