Trinitycore: [3.3.5] Event: Stranglethorn Fishing Extravaganza Turn-ins

[TheWinchesters]

Description:
This event spawns the quest giver for the event.

Current behaviour:
DB shows that length is 180 (3 hours) but ingame, .event inf 62 shows:

• Length: 2 day(s)
• Next state change: 2019-05-03_00-00-00

Stranglethorn Fishing Extravaganza is a Sunday event and the quest giver is not in the realm when the pools are active.

Expected behaviour:
I have did some research and it looks like the NPC should spawn when the pools spawns and should be there for 3 hours.

Branch(es): 3.3.5
TC rev. hash/commit: f04e90f
Operating system: Win 8.1

[illfated]

TC>.server debug
TrinityCore rev. 33c58b4aaf4a 2019-02-03 17:01:05 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.1.0j 20 Nov 2018 (library: OpenSSL 1.1.0j 20 Nov 2018)
Using Boost version: 1.69.0
Using MySQL version: 5.6.41
Using CMake version: 3.13.2
Compiled on: Windows 10.0.17763
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 252191207 bytes
vmaps directory located in ./vmaps. Total size: 588247501 bytes
mmaps directory located in ./mmaps. Total size: 2153471900 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.64
TC>_

Confirmed. Last week I saw the turn-in quest enders in Booty Bay on Thursday, which does not fit in with the Stranglethorn Fishing Extravaganza.

TC> event info 15
Event 15: Stranglethorn Fishing Extravaganza Fishing Pools
Start: 2016-10-30_15-00-00 End: 2020-12-31_06-00-00 Occurence: 7 Day(s)  Length: 2 Hour(s)
Next state change: 2019-02-10_15-00-00

TC> event info 62
Event 62: Stranglethorn Fishing Extravaganza Turn-ins
Start: 2019-05-03_00-00-00 End: 2020-12-31_06-00-00 Occurence: 7 Day(s)  Length: 2 Day(s)
Next state change: 2019-05-03_00-00-00

[TheWinchesters]

The weird thing is that "Start" changes after the event is active.
I discovered it the first week of January.
That week, .event info 62 showed that the 'Next state change' would be '2019-02-01' and it was active for 2 days. I waited because I thought that it would be ok after that date.
After last sunday, 'Start' and 'Next state change' are 2019-05-03_00-00-00

[illfated]

Maybe it is unstable because there is no correct time for event 62 in DB until the 3rd of May 2019 ?

---

edit: Hmm, maybe I have misunderstood it completely. I will try rebuilding TDB 335.64 a couple of times to see if it gets any better.

[TheWinchesters]

Maybe it is unstable because there is no correct time for event 62 in DB until the 3rd of May 2019 ?

I thought the same when .event info 62 was 'Start: 2019-02-01_00-00-00'.
Event started that day, and ended two days later.
After that, .event info 62 has a new 'Start' date.

[illfated]

Thanks for pointing out the details. Just a quick update on what is in TDB 335.64 @ rev. 33c58b4aaf4a 2019-02-03 17:01:05 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static) :

SELECT * FROM `game_event` WHERE `description` LIKE '%Stranglethorn%';

eventEntry       start_time             end_time      occurence  length  holiday  holidayStage  description                                       world_event  announce
----------  -------------------  -------------------  ---------  ------  -------  ------------  ------------------------------------------------  -----------  --------
        14  2016-10-29 01:00:00  2020-12-31 06:00:00      10080    1440        0             0  Stranglethorn Fishing Extravaganza Announce                 0         2
        15  2016-10-30 15:00:00  2020-12-31 06:00:00      10080     120      301             0  Stranglethorn Fishing Extravaganza Fishing Pools            0         2
        62  2016-10-30 15:00:00  2020-12-31 06:00:00      10080     180      376             1  Stranglethorn Fishing Extravaganza Turn-ins                 0         2

The odd thing is that the start_time values look OK for now, because they have not yet been active.
But as you pointed out, something is going to change part of this content next time the event is active.

[TheWinchesters]

This is what I found:
event 62 has 'holiday' = 376
'holiday' field description: Holiday ID from Holidays DBC file.
I have read Holidays.dbc and 376 has description 'Calendar_DarkmoonFaireTerokkar'.

Could this value be the cause of the problem?

[illfated]

That seems very likely. Could you also check what the _actual_ Holiday ID is for all 3 Stranglethorn Fishing Extravaganza events? I suspect that 2 or maybe all 3 Holiday IDs are wrong.

[TheWinchesters]

301 and 424 have description Calendar_FishingExtravaganza
In the db, 301 is Stranglethorn Fishing Extravaganza and 424 is Kalu'ak fishing derby.
Using Kalu'ak event info in db (because it is a similar event and that one is working correctly), I did the same with Stranglethorn Fishing Extravaganza and removed holiday = 376 for eventid 62. Looks like it works.

I noticed this because Darkmoon faire (Mulgore) and Darkmoon faire Building (Mulgore) are wrong too.
Both of them are active at the same time because the duration of Darkmoon faire Building (Mulgore) is wrong.

[illfated]

Nice. Would you like to propose a solution by posting the necessary SQL code block in your next comment? I am out in the woods, in my friend's cabin, so I only got my phone here. (Will be home again in the evening, though.)

---

Oh well. Never mind. I am back home again. I will take a look at the .dbc file too.

[illfated]

Just to get some more feedback: Would it not be correct to add the holiday ID to all 3 events? i.e. / e.g.

--  Stranglethorn Fishing Extravaganza holiday ID (301)
UPDATE `game_event` SET `holiday`=301 WHERE `eventEntry` IN (
 14,  -- Stranglethorn Fishing Extravaganza Announce
 15,  -- Stranglethorn Fishing Extravaganza Fishing Pools
 62); -- Stranglethorn Fishing Extravaganza Turn-ins

---

edit: I know, technically only 2 of those lines are needed, but could be useful in case someone had changed their local holiday IDs.
Anyway, if one of the values already is the same as the update value, that row will be skipped.

[TheWinchesters]

Not sure what is the best solution. This is what I thought:

• Kalu'ak Fishing Derby Turn-ins works
• Kalu'ak Fishing Derby Turn-ins has holiday = 0 and holidayStage = 0
• Let's do the same with Stranglethorn Fishing Extravaganza Turn-ins to see what happens.
  It worked.

UPDATE `game_event` SET `holiday` = '0', `holidayStage` = '0' WHERE (`eventEntry` = '62');

And for Darkmoon Faire Building events:
I have used event Darkmoon Faire Building (Elwynn Forest) as example because it is the only one working correctly

UPDATE `game_event` SET `length` = '4320', `holiday` = '375', `holidayStage` = '1' WHERE (`eventEntry` = '71');
UPDATE `game_event` SET `length` = '4320', `holiday` = '376', `holidayStage` = '1' WHERE (`eventEntry` = '77');

[illfated]

Fair enough, looks like you have done some testing too.
TC SQL codestyle tip: remove apostrophes around numbers
(except for aura IDs when field is defined as text).

Example:

-- Stranglethorn Fishing Extravaganza Turn-ins
UPDATE `game_event` SET `holiday`= 0, `holidayStage`= 0 WHERE (`eventEntry`= 62);

-- Darkmoon Faire Building (Mulgore / Terokkar Forest)
UPDATE `game_event` SET `length`= 4320, `holiday`= 375, `holidayStage`= 1 WHERE (`eventEntry`= 71);
UPDATE `game_event` SET `length`= 4320, `holiday`= 376, `holidayStage`= 1 WHERE (`eventEntry`= 77);

(yes, I know that SQL editors often put apostrophes around number values in the output window)

[LordWaycrest]

I'm assuming there is a fix confirmed, when will this fix be made official?

[illfated]

Unfortunately, there is no confirmed fix yet (at least that I know), I have not had time to test anything useful myself. I was hoping someone else would post a useful suggestion for further testing, but that has not happened yet.

@offl : Do you have any suggestions for how to solve this?

[offl]

Test https://github.com/TrinityCore/TrinityCore/issues/23011#issuecomment-490624237? :)

[illfated]

@offl : Thank you for your reply, we should definitely test it.
@jackpoz : Could we add that to the current TC server or maybe on a test server?

[LordWaycrest]

@offl : Thank you for your reply, we should definitely test it.
@jackpoz : Could we add that to the current TC server or maybe on a test server?

Probably best on a test server since we are testing.

[illfated]

Not many people are using the TC server, mainly 1 at a time (Aokromes, jackpoz, sometimes me, maybe Killyana).

• https://tcubuntu.northeurope.cloudapp.azure.com/
• https://tcubuntu.northeurope.cloudapp.azure.com/grafana
• https://tcubuntu.northeurope.cloudapp.azure.com/aowow/

[LordWaycrest]

Is it open to the public? I don't mind coming to help test

* Never mind, just checked the links. Which one are you on? *

[illfated]

Currently, tcubuntu.northeurope.cloudapp.azure.com is using the straight unchanged 3.3.5 source from the TC repository.

That is why I asked jackpoz if the SQL above can be added somewhere, because I currently don't have a local core or working TC compiler setup on my computer.

[LordWaycrest]

Currently, tcubuntu.northeurope.cloudapp.azure.com is using the straight unchanged 3.3.5 source from the TC repository.
That is why I asked jackpoz if the SQL above can be added somewhere, because I currently don't have a local core or working compile setup on my computer.

I have a public test realm, if that's any good?

[illfated]

I presume I will have to return to this topic next weekend, since the main point here is to test if the changes will make the Stranglethorn Fishing Extravaganza events work as on retail (Blizzard), which is in the timeframe 14:00 - 16:00 (server time) every Sunday.

[LordWaycrest]

I presume I will have to return to this topic next weekend, since the main point here is to test if the changes will make the Stranglethorn Fishing Extravaganza events work as on retail (Blizzard), which is in the timeframe 14:00 - 16:00 (server time) every Sunday.

I can apply that SQL to the database and go from there, unless you want to wait.

[illfated]

I presume I will have to return to this topic next weekend, since the main point here is to test if the changes will make the Stranglethorn Fishing Extravaganza events work as on retail (Blizzard), which is in the timeframe 14:00 - 16:00 (server time) every Sunday.

I can apply that SQL to the database and go from there, unless you want to wait.

Sure thing, feel free to apply the SQL. The more servers we can test it on, the better chance we stand to find out if it is the solution. 👍

[illfated]

BTW, I recommend using the TC SQL codestyle format:

-- Stranglethorn Fishing Extravaganza Turn-ins
UPDATE `game_event` SET `holiday`= 0, `holidayStage`= 0 WHERE `eventEntry`= 62;

-- Darkmoon Faire Building (Mulgore / Terokkar Forest)
UPDATE `game_event` SET `length`= 4320, `holiday`= 375, `holidayStage`= 1 WHERE `eventEntry`= 71;
UPDATE `game_event` SET `length`= 4320, `holiday`= 376, `holidayStage`= 1 WHERE `eventEntry`= 77;

(<== Original solution by @TheWinchesters ==>)

[LordWaycrest]

BTW, I recommend using the TC SQL codestyle format:
-- Stranglethorn Fishing Extravaganza Turn-ins
UPDATE game_event SET holiday= 0, holidayStage= 0 WHERE eventEntry= 62;

-- Darkmoon Faire Building (Mulgore / Terokkar Forest)
UPDATE game_event SET length= 4320, holiday= 375, holidayStage= 1 WHERE eventEntry= 71;
UPDATE game_event SET length= 4320, holiday= 376, holidayStage= 1 WHERE eventEntry= 77;
(<== Original solution by @TheWinchesters ==>)

I'll make you an account and PM details if you want.

Realmlist is beta.eu.logon.ideagaming.com

[illfated]

Thanks, I will have to get back to you on that later. I need to get some sleep before I start my regular work week (9;00-5:00 CET, with 1 hour additional travel time before & after).

[LordWaycrest]

Thanks, I will have to get back to you on that later. I need to get some sleep before I start my regular work week (9;00-5:00 CET, with 1 hour additional travel time before & after).

Okay matey, have a good one :)

[Jildor]

Seems wrong holiday yes, added here: https://github.com/TrinityCore/TrinityCore/commit/951fa46fe9b14a9e275ac9306b2346959e40e3e5#diff-07e3e9dbb0ea1e070fc108901cf6f155R187

@Killyana could we push https://github.com/TrinityCore/TrinityCore/issues/23011#issuecomment-583908954 ?

[TheWinchesters]

The notification of this almost gave me a heart attack.
Thank you.