Trinitycore: Crash in Player.cpp related to questgiver

[TheWinchesters]

This is a bad report because I have nothing but a crashlog.
The only thing I know is that it is related to:
if (auto questStatus = questgiver->ToCreature()->AI()->GetDialogStatus(this))

https://gist.github.com/TheWinchesters/70a1621a31142224906678f0bdc8dcf9

Branch: 3.3.5
TC Rev: 7baf5b2
OS: Win 8.1 / Debian 9

[illfated]

Your debug crash log with backtrace is a good start.
I have seen a lot worse than this, so don't worry.

[jackpoz]

@Hir0shi every time you want to confirm a crash you must fill a proper crash report with revision, platform, TDB version and adding the link to the crashlog uploaded to Gist . Simply writing "confirm" is totally useless.

[jackpoz]

this crash happens somewhere in an instance as there is InstanceMap::Update() in the callstack.
The questgiver has guid F130005D400001C2, which should mean (I forgot the rules here) that it's NPC 23872 Coren Direbrew .
Could you queue through LFD for blackrock depths and see if talking to Coren Direbrew triggers the issue every time ? Or could anyone else give it a try and tell if it works or crashes ? Thanks

[TheWinchesters]

I have tried and nothing.
I even tried that several characters interact with Coren at the same time, one with quest 11486, other with quest 11454, and other one made Coren enemy.
I will keep trying different things.

edit: I have tried everything that come to my mind and still nothing.

[jackpoz]

@TheWinchesters any news about this issue ? did it happen again or should we just close it ?
It could be questgiver->ToCreature()->AI() returned NULL at that point, so maybe we could add a NULL check there

[Keader]

@jackpoz any change of this questgiver being controlled (mind control) by a other faction player?
Mind controlled npcs return null in AI()

[jackpoz]

@Keader I thought the same and wrote a patch before reading your comment :)
Maybe there's even a Coverity/PVS-Studio issue about it but I haven't had time to check those in a while.

Fixed in https://github.com/TrinityCore/TrinityCore/commit/6859dfa2d157f0d174004a00a9d047d6eb38f9a1