Trinitycore: QUEST New Recruit - [13143] Charm Issue

[pedroevil51]

Description:

Charm Problem - On quest New Recruit - [13143]

Current behaviour:

You use the item - [43315]
The mob in question gets charmed, but won't follow you
Expected behaviour:
The mob should follow you once you charmed him
Steps to reproduce the problem:

1. Add the quest New Recruit - [13143]
2. Go to the quest location and find the NPC [Lithe Stalkers]
3. Charm the NPC using the item - [43315]

Branch(es):

3.3.5

TC rev. hash/commit:
https://github.com/TrinityCore/TrinityCore/commit/408ce487323504fcdf693b7dfa581b74d5073971

Operating system: Win 2012

[illfated]

Not sure if this is a charm issue (unless it worked just before the latest changes yesterday).
To me, it looks more like movement issues (waypoint related?).
Then again, I remember this kind of issue a half year ago too.

[dr-j]

When i originally scripted this had to hack script a bit to get this to work as has remember this problem 4 years ago had to get the lithe stalker to follow invoker on spell hit but maybe not working now

[ZenoX92]

In the old core version I'm currently using (TrinityCore rev. 1cc3d33 2018-02-19 20:21:57), this is working just fine.

[Rushor]

justfollow simply does not work anymore after charming i guess

spelleffect is:

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 100
Targets (25, 0) (TARGET_UNIT_TARGET_ANY, NO_TARGET)
Aura Id 177 (SPELL_AURA_AOE_CHARM), value = 100, misc = 0 (0), miscB = 0, periodic = 0

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 0
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 1, misc = 0 (0), miscB = 0, periodic = 0

[Rushor]

fix...

-- Lithe Stalker SAI
SET @ENTRY := 30894;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,1,8,0,100,512,58151,0,0,0,64,1,0,0,0,0,0,7,0,0,0,0,0,0,0,"Lithe Stalker - On Spellhit 'Subdued Lithe Stalker' - Store Targetlist"),
(@ENTRY,0,1,0,60,0,100,512,100,100,2000,2000,29,2,2,0,0,0,0,12,1,0,0,0,0,0,0,"Lithe Stalker - On Update - Start Follow <unsupported target type>"),
(@ENTRY,0,2,3,8,0,100,512,58178,0,0,0,11,58190,0,0,0,0,0,12,1,0,0,0,0,0,0,"Lithe Stalker - On Spellhit 'CSA Dummy Effect (25 yards)' - Cast 'Geist Return Kill Credit'"),
(@ENTRY,0,3,0,61,0,100,512,58178,0,0,0,41,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - On Spellhit 'CSA Dummy Effect (25 yards)' - Despawn Instant");

[Killyana]

Yes the issue is charming a npc will not make it follow you unless commanded, this follow action is not even needed normally.
You can test with .cast 260 in any creature and it will not follow.
Also lot of things are wrong or missing for this quest, I will rewrite it once the follow issue fixed

[Killyana]

``sql -- Lithe Stalker SAI SET @ENTRY := 30894; DELETE FROMsmart_scriptsWHEREentryorguid=@ENTRY ANDsource_type=0; DELETE FROMsmart_scriptsWHEREentryorguidIN (@ENTRY*100) ANDsource_type=9; INSERT INTOsmart_scripts(entryorguid,source_type,id,link,event_type,event_phase_mask,event_chance,event_flags,event_param1,event_param2,event_param3,event_param4,action_type,action_param1,action_param2,action_param3,action_param4,action_param5,action_param6,target_type,target_param1,target_param2,target_param3,target_x,target_y,target_z,target_o,comment`) VALUES
(@ENTRY,0,0,0,2,0,100,1,1,25,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - On health pct - Say text"),
(@ENTRY,0,1,0,8,0,100,513,58151,0,0,0,11,43979,1,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - On Spellhit 'CSA Dummy Effect (25 yards)' - Cast full heal"),
(@ENTRY,0,2,0,34,0,100,513,8,1,0,0,41,10000,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - On movement informer - Despawn"),
(@ENTRY,0,3,0,8,0,100,513,58178,0,0,0,80,@ENTRY100,2,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - On Spellhit 'CSA Dummy Effect (25 yards)' - Action list"),
(@ENTRY100,9,0,0,0,0,100,512,0,0,0,0,11,58190,0,0,0,0,0,23,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Cast 'Geist Return Kill Credit'"),
(@ENTRY100,9,1,0,0,0,100,512,0,0,0,0,28,58151,0,0,0,0,0,23,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Remove aura"),
(@ENTRY100,9,2,0,0,0,100,512,0,0,0,0,18,768,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Set unit flag"),
(@ENTRY100,9,3,0,0,0,100,512,0,0,0,0,8,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Set passif"),
(@ENTRY100,9,4,0,0,0,100,512,0,0,0,0,2,35,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Set faction"),
(@ENTRY100,9,5,0,0,0,100,512,0,0,0,0,117,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Lithe Stalker - Action list - Disable Evade"),
(@ENTRY100,9,6,0,0,0,100,512,0,0,0,0,69,1,0,0,0,0,0,8,0,0,0,6463.089, 2039.219, 570.721985,0,"Lithe Stalker - Action list' - Move to pos");

DELETE FROM creature_text WHERE CreatureID IN (@ENTRY);
INSERT INTO creature_text (CreatureID, GroupID, ID, Text, Type, Language, Probability, Emote, Duration, Sound, BroadcastTextId, TextRange, comment) VALUES
(@ENTRY, 0, 0, "The Lithe Stalker is weakened by the assault.", 16, 0, 100, 0, 0, 0, 31580, 0, "Lithe Stalker");

DELETE FROM conditions WHERE SourceTypeOrReferenceId=22 AND SourceEntry IN (30894);
DELETE FROM conditions WHERE SourceTypeOrReferenceId=17 AND SourceEntry IN (58151);
INSERT INTO conditions (SourceTypeOrReferenceId, SourceGroup, SourceEntry, SourceId, ElseGroup, ConditionTypeOrReference, ConditionTarget, ConditionValue1, ConditionValue2, ConditionValue3, NegativeCondition, ErrorType, ErrorTextId, ScriptName, Comment) VALUES
(17, 0, 58151, 0, 0, 38, 1, 25, 4, 0, 0, 0, 0, '', 'Subdued Lithe Stalker - 25% health or less'),
(17, 0, 58151, 0, 0, 31, 1, 3, 30894, 0, 0, 12, 0, '', 'Subdued Lithe Stalker - only for Lithe Stalker'),
(22, 4, 30894, 0, 0, 1, 1, 58151, 0, 0, 0, 0, 0, '', 'Only run AI if Lithe Stalker has Aura (Subdued Lithe Stalker)');