Trinitycore: Warrior Charge Underwater Facing the Wrong Way

[WOW-Reborn]

Description:

Warrior charge underwater causes the warrior to charge at the mob but faces the wrong way.

Current behaviour:

When your underwater fighting turtles for instance and you use charge the charge works but when you stop at the mob you are facing the wrong way.

Expected behaviour:

You should be able to use the charge underwater and stop right in front of the mob so you can instantly attack without having to move around to get the mob in front of you.

Steps to reproduce the problem:

1. Go anywhere where there is deep water and mobs
2. Cast charge on any mob and your toon will run at them.
3. Then you are greeted by the error that you are facing the wrong way.

Branch(es):

3.3.5

TC rev. hash/commit:

6726126664db+

Operating system:

Windows Server 2012

[illfated]

out of curiosity: does the warrior charge end before or after the target?
if the charge ends on the other side of the target, it could be a movement calculation issue.
on the other hand, if the warrior stops before the target, the orientation would be the problem.

[WOW-Reborn]

@illfated it appears to shoot you just a tad past them. Then you have to turn around to attack.

[illfated]

Very well, thanks for the feedback. I am fairly sure I have noticed it while testing warrior class characters, but never thought it was a permanent issue, more or less a maps/mmaps issue related to other charge issues already open here in the tracker. Since you have tested it in detail like you documented above, it is more likely to be a core issue.

[Killyana]

Th issue is when you charge a creature in water you will end on top of it, the issue is not with facing but the height end position.

creature position: X: 6627.782227 Y: 711.116455 Z: -8.365127
Player end position: X: 6627.782227 Y: 711.116455 Z: -4.365127
4 yards on top of the creature

To reproduce the issue:
.go xyz 6627.782227, 711.116455, -8.365127 1
.npc add temp 2185
get creature coords
charge the creature and get player's coords
Notice 4 yards difference

[Faq]

me summons @Ovahlord

[jackpoz]

caused most likely by https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/game/Spells/Spell.cpp#L5512

[Killyana]

We must fix https://github.com/TrinityCore/TrinityCore/issues/23326 first, as I cannot charge any creature in water, it always returns no path available.

[jackpoz]

I was able to charge just fine at the coordinates you provided. maybe the target has to be 4 yards underground ?

[jackpoz]

https://github.com/TrinityCore/TrinityCore/pull/24010