Trinitycore: [3.3.5] Auto Attack re-initiates on click

[oXL0C0Xo]

Description:
Auto Attack re-initiates on additional right clicks to target.

Current behaviour:
Right clicking on an enemy re-initiates Auto Attack and replays the animation. Also it seems to trigger the attack delay, so if you continually click on a mob, you will never actually attack them.

Expected behaviour:
Once Auto Attack is initiated, it should not be disabled until target is dead or player changes targets. It should not re-initiate Auto Attack or replay attacking animation on additional clicks.

Steps to reproduce the problem:
Create a character, and continually right click on them to trigger Auto Attack with a weapon equipped.

Branch(es):
3.3.5

TC rev. hash/commit:
TrinityCore rev. 029c4232a7f5 2018-06-23 22:57:44 +0200 (3.3.5 branch) (Unix, RelWithDebInfo, Static)

**Operating system:
Server: Ubuntu 17.10
Client: Windows 10 Pro

[Killyana]

For me it looks only visual, the auto attack delay is always the same.

[oXL0C0Xo]

Upon further review, it does seem that the attacks are triggering correctly, just the animation is restarting (so you can look like you are attacking faster than you really are).

[Langerz82]

Haxxxxxx!

[Treeston]

This seems to be a client-side issue. The server never even receives CMSG_ATTACKSWING opcodes for these clicks, they do nothing except impact the local client visual.

If anything, it's possible the server isn't setting some flag properly that'd cause the client to disregard these clicks locally, though I'm unsure. @Shauren could you give this a look if you find the time?

[Killyana]

Could be related to https://github.com/TrinityCore/TrinityCore/issues/21680

[Treeston]

Entirely unrelated.

[oXL0C0Xo]

Issue still exists in current build be65f7d

[illfated]

( https://github.com/TrinityCore/TrinityCore/commit/be65f7d60e66d4c43f8fe9d779e5b4214afb91bf )