Trinitycore: Remove Curse "Nothing to dispell" 3.3.5

[Jasonqt]

Description:

Remove Curse wont dispell target if you have the same curse applied

Current behaviour:

Remove Curse doesn't work properly. When you try to remove a curse from a friendly target when you both have the same curse applied, it says "Nothing to dispell". However, if you dont have said curse, and your friendly target does, It works. (Tested on Mage and Druid)
If this is a crash, post the crashlog (upload to https://gist.github.com/).

Expected behaviour:

Even if you have same curse as your partymember(s), you should be able to dispell target.

Steps to reproduce the problem:

1. Go to molten core / .go creature 56737
2. Attack Gehennas, and wait for her to apply the debuff to you and your target
3. Try to dispell your partymember(s)

Branch(es):

Tested only on 3.3.5

TC rev. hash/commit: 718742005c3b

Debug command:
TrinityCore rev. 718742005c3b+ 2018-06-17 17:03:10 +0200 (3.3.5 branch) (Win64, Release, Static)
Using SSL version: OpenSSL 1.0.2l 25 May 2017 (library: OpenSSL 1.0.2l 25 May 2017)
Using Boost version: 1.65.1
Using MySQL version: 10.1.30-MariaDB
Using CMake version: 3.11.2
Compiled on: Windows 6.1.7601
Automatic database updates are disabled for all databases!
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Disabled
MMAPs status: Disabled
maps directory located in ./maps. Total size: 252191207 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS

Operating system: Tested on Debian 9, Windows 7 & 10.

[Langerz82]

I created a party of two. Casted "Curse of the elements" on both party members, used "Remove curse" on target party member and its working as intended. Whats the debuff spell id the creature is casting?

Tested with: http://www.wowhead.com/spell=19716/gehennas-curse - can still dispell.

[Jasonqt]

I forgot to mention, if you do it that way it will work. You have to make a mob cast it on you for it not to work.

[Langerz82]

Can you give an example thats not in an instance, with commands to get there. (Im a WoW noob) XD

[illfated]

GM character can use .go creature Gehennas and then .summon (other player name)
There are mobs in Stratholme who cast curses too, you may want to check there.
(GM command .tele stratholme to get to the entrance, then .summon (player name)

edit: .go creature 56737 is mentioned in the issue comment, really?
(http://www.wowhead.com/npc=56737/ut-nam - added in MoP)
Try Gehennas' ID: .go creature id 12259 + .summon (other player name)

[Jasonqt]

Apologies. When i do .go creature 56737 i get to gehennas, i assumed it was the same for everyone using TC.

[Langerz82]

I used two GM accounts, Got into instance, put GOD mode on (so i dont die instantly :P). When Gehannas Curse is cast, I can still remove it even though I had it on the casting Dispel Character.

I'm using an older branch could this be the reason its working for me?

rev: TrinityCore rev. ed63d15dfe95 2018-02-18 18:56:29

[Killyana]

I cannot reproduce on rev. 8a312046b221

[illfated]

@Jasonqt : My apologies, I forgot to check the exact wording of your command line.
You did not use 'id' which means you went to the guid of Gehennas, not the id. Fair enough.

[Cillez]

I can confirm it happend to me on the rev OP has noted.
@Langerz82 i went back to feburary myself and its working fine, so its something that was changed between february-June.
Ill try latest rev and report back

EDIT:
Still not working on 029c423

@Killyana did you do what he stated in his second comment?

[Killyana]

I updated the core rev. 2e6100919d77
Now I'm not able to dispel another player from my party, it tells me "there's nothing to dispel"
If I have the same aura as the player from my party, if I dispel my char the other player will be dispelled, also if I .unaura my char the aura will also be dispelled from the other player.

If I unaura the other player the aura will reapply as soon as it's dispelled, it's like it was linked to my char.

I use https://woehead.way-of-elendil.fr/?spell=2782 to dispel https://woehead.way-of-elendil.fr/?spell=19716

[Langerz82]

think I got something, will provide a patch later.

[Langerz82]

See if this works. Seems to be working for me. The only other query I have is should dispell get rid of the parties buffs or just a single target? Cause it's removing it like a party buff.

[Killyana]

It must be removed only from the dispelled player.

[Langerz82]

TODO: Make Remove Curse only dispell targets Curse.

[Langerz82]

Here is a patch for testing. It makes allot of changes so there may be bugs. Needs testing thoroughly with all aura spells as it makes logic adjustments to them.

See:
https://gist.github.com/Langerz82/3ff58eb6b82a6bfd1e3e21cb55bd22c0

edit:
ok, ready for testing. Only briefly tested do NOT use on production servers as there may be memory leaks and/or unnecessary processing overhead.

edit:
Let the errors I mean testing begin! Ha

[Langerz82]

AoE's like Blizzard dont seem to be working for me with this patch, I think. Can someone else test it too?

[Cillez]

Blizzard and Volley seems to be bugged from that patch. Only other spell i could think of is shadowfury for warlocks, but thats working fine.

tested Death and dec**, also works.

[Langerz82]

I think that the following is causing the targeted AoE's not to work. Could be wrong test without it.

diff --git a/src/server/game/Spells/Auras/SpellAuras.cpp b/src/server/game/Spells/Auras/SpellAuras.cpp
index 142e6f8b4e..c15fcbd540 100644
--- a/src/server/game/Spells/Auras/SpellAuras.cpp
+++ b/src/server/game/Spells/Auras/SpellAuras.cpp
@@ -728,9 +728,8 @@ void Aura::UpdateTargetMap(Unit* caster, bool apply)
             {
                 // aura is already applied, this means we need to update effects of current application
                 itr->first->_UnapplyAura(aurApp, AURA_REMOVE_BY_DEFAULT);
+                itr->first->_CreateAuraApplication(this, itr->second);
             }
-
-            itr->first->_CreateAuraApplication(this, itr->second);
             ++itr;
         }
     }

[Langerz82]

Blizzard is bugged for the revision:
TrinityCore rev. 2e6100919d77 2018-06-25

It's unrelated to this patch.

[Langerz82]

Is this patch working and fix the issues?

See:
https://gist.github.com/Langerz82/3ff58eb6b82a6bfd1e3e21cb55bd22c0

[jackpoz]

@Langerz82 please open a PR when posting C++ changes

[Langerz82]

I had trouble in the past making branches as my base was a mess. I'll give it another try soon. ^-^