Trinitycore: Quest: "By Any Means Necessary" not Blizz like.

[Jonne733]

Description:
When you are doing the quest By Any Means Necessary your are suppose to locate Empoor, initiate conversation with him, defeat him and then turn the quest in to him.

Current behaviour:
You can just turn the quest in straight away, negating ever having to fight him.

Expected behaviour:
When talking to Empoor he should at first not have the yellow "?" available but instead have "gossip_menu_option" ID 7704 selectable. Which when clicked on should turn both Empoor and his bodyguard hostile towards the player and Empoor should say "What is the meaning of this?!".
After you gotten Empoor down to 1HP, both he and his bodyguard should revert back to being friendly and the yellow "?" apear above Empoor's head.

Steps to reproduce the problem:
Add quest 9978 to your questlog and locate Empoor.

Branch(es): 3.3.5
TC rev. hash/commit: 5fa783bd34d8e5b32aded6b87a1e4b196b7c4022
TDB version: ed63d15
Operating system: Windows 10

Additional info taken from playing on live server

• If you leave combat with the two npc's they will revert to friendly status after 20 sec and return to patrolling
• After you defeat Empoor you will have 120 sec on you to turn the quest in, if you don't he will say "I'm leaving now!" and go back to patrolling and the yellow "?" will disappear.
• Only by taking down Empoor's HP to 1 will both NPC's turn friendly, his bodyguard can be straight out killed with no effect.
• YouTube video showing the fight here

[illfated]

Missing SmartAI script for the quest fight. The only line present in smart_scripts is for his Lightning Shield ability (http://www.wowhead.com/spell=12550/lightning-shield)

SELECT * FROM `smart_scripts` WHERE `entryorguid` = 18482;

entryorguid  source_type      id    link  event_type  event_phase_mask  event_chance  event_flags  event_param1  event_param2  event_param3  event_param4  event_param5  action_type  action_param1  action_param2  action_param3  action_param4  action_param5  action_param6  target_type  target_param1  target_param2  target_param3  target_x  target_y  target_z  target_o  comment
-----------  -----------  ------  ------  ----------  ----------------  ------------  -----------  ------------  ------------  ------------  ------------  ------------  -----------  -------------  -------------  -------------  -------------  -------------  -------------  -----------  -------------  -------------  -------------  --------  --------  --------  --------  ---------------------------------------------
      18482            0       0       0          25                 0           100            1             0             0             0             0             0           11          12550              0              0              0              0              0            1              0              0              0         0         0         0         0  Empoor - On Respawn - Cast 'Lightning Shield'

[ZenoX92]

This should fix both this issue and #22016. @Jonne733, can you test it and tell me if I missed something?
``sql -- Quest "By Any Means Necessary" UPDATEquest_template_addonSETSpecialFlags=2 WHEREID`=9978;

-- Empoor
DELETE FROM gossip_menu WHERE MenuID=7704 AND TextID=9406;
INSERT INTO gossip_menu (MenuID, TextID, VerifiedBuild) VALUES
(7704,9406,0);

DELETE FROM gossip_menu_option WHERE MenuID=7704 AND OptionID=1;
INSERT INTO gossip_menu_option (MenuID, OptionID, OptionIcon, OptionText, OptionBroadcastTextID, OptionType, OptionNpcFlag, ActionMenuID, ActionPoiID, BoxCoded, BoxMoney, BoxText, BoxBroadcastTextID, VerifiedBuild) VALUES
(7704,1,0,"Tell me again what you know!",16123,1,1,0,0,0,0,"",0,0);

DELETE FROM conditions WHERE SourceTypeOrReferenceId=14 AND SourceGroup=7704 AND SourceEntry=9406;
DELETE FROM conditions WHERE SourceTypeOrReferenceId=15 AND SourceGroup=7704 AND SourceEntry=1;
INSERT INTO conditions (SourceTypeOrReferenceId, SourceGroup, SourceEntry, SourceId, ElseGroup, ConditionTypeOrReference, ConditionTarget, ConditionValue1, ConditionValue2, ConditionValue3, NegativeCondition, ErrorType, ErrorTextId, ScriptName, Comment) VALUES
(14,7704,9406,0,0,28,0,9978,0,0,0,0,0,"","Show gossip text 9406 if quest 'By Any Means Necessary' is complete"),
(15,7704,1,0,0,8,0,9978,0,0,0,0,0,"","Show gossip option 1 if quest 'By Any Means Necessary' is rewarded"),
(15,7704,1,0,0,14,0,9979,0,0,0,0,0,"","Show gossip option 1 if quest 'Wind Trader Lathrai' is not taken"),
(15,7704,1,0,1,28,0,9978,0,0,0,0,0,"","Show gossip option 1 if quest 'By Any Means Necessary' is complete");

DELETE FROM smart_scripts WHERE entryorguid=18482 AND source_type=0;
DELETE FROM smart_scripts WHERE entryorguid IN (1848200,1848201,1848202) AND source_type=9;
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, event_param5, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_x, target_y, target_z, target_o, comment) VALUES
(18482,0,0,0,11,0,100,0,0,0,0,0,0,83,2,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Respawn - Remove Npc Flag Questgiver"),
(18482,0,1,0,11,0,100,0,0,0,0,0,0,42,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Respawn - Set Invincibility at 1 HP"),
(18482,0,2,4,62,0,100,0,7704,0,0,0,0,80,1848200,2,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Gossip Option 0 Selected - Run Script"),
(18482,0,3,4,62,0,100,0,7704,1,0,0,0,80,1848200,2,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Gossip Option 1 Selected - Run Script"),
(18482,0,4,0,61,0,100,0,0,0,0,0,0,78,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Gossip Option Selected - Reset All Scripts"),
(18482,0,5,0,2,0,100,1,0,1,0,0,0,80,1848201,2,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - Between 0-1% Health - Run Script"),
(18482,0,6,0,0,0,100,0,3000,5000,9000,12000,0,11,12548,0,0,0,0,0,2,0,0,0,0,0,0,0,"Empoor - In Combat - Cast 'Frost Shock'"),
(18482,0,7,0,23,0,100,0,12550,0,1000,2000,0,11,12550,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Has No Aura 'Lightning Shield' - Cast 'Lightning Shield'"),
(18482,0,8,0,7,0,100,0,0,0,0,0,0,80,1848202,2,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Evade - Run Script"),
(1848200,9,0,0,0,0,100,0,0,0,0,0,0,2,1679,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Set Faction 1679"),
(1848200,9,1,0,0,0,100,0,0,0,0,0,0,45,1,1,0,0,0,0,19,18483,0,0,0,0,0,0,"Empoor - On Script - Set Data 1 to Empoor's Bodyguard"),
(1848200,9,2,0,0,0,100,0,0,0,0,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Say Line 0"),
(1848200,9,3,0,0,0,100,0,0,0,0,0,0,49,0,0,0,0,0,0,21,40,0,0,0,0,0,0,"Empoor - On Script - Start Attacking"),
(1848201,9,0,0,0,0,100,0,0,0,0,0,0,2,35,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Set Faction 35"),
(1848201,9,1,0,0,0,100,0,0,0,0,0,0,27,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Stop Combat"),
(1848201,9,2,0,0,0,100,0,0,0,0,0,0,45,2,2,0,0,0,0,19,18483,0,0,0,0,0,0,"Empoor - On Script - Set Data 2 to Empoor's Bodyguard"),
(1848201,9,3,0,0,0,100,0,0,0,0,0,0,15,9978,0,0,0,0,0,18,50,0,0,0,0,0,0,"Empoor - On Script - Complete Quest 'By Any Means Necessary'"),
(1848201,9,4,0,0,0,100,0,0,0,0,0,0,82,2,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Add Npc Flag Questgiver"),
(1848201,9,5,0,0,0,100,0,120000,120000,0,0,0,83,2,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Remove Npc Flag Questgiver"),
(1848201,9,6,0,0,0,100,0,0,0,0,0,0,1,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Say Line 1"),
(1848202,9,0,0,0,0,100,0,20000,20000,0,0,0,2,35,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor - On Script - Set Faction 35");

DELETE FROM creature_text WHERE CreatureID=18482;
INSERT INTO creature_text (CreatureID, GroupID, ID, Text, Type, Language, Probability, Emote, Duration, Sound, BroadcastTextId, TextRange, comment) VALUES
(18482,0,0,"What is the meaning of this?!",12,0,100,0,0,0,15487,0,"Empoor"),
(18482,1,0,"I'm leaving now!",12,0,100,1,0,0,15491,0,"Empoor");

-- Empoor's Bodyguard
UPDATE creature_template SET AIName="SmartAI" WHERE entry=18483;
DELETE FROM smart_scripts WHERE entryorguid=18483 AND source_type=0;
INSERT INTO smart_scripts (entryorguid, source_type, id, link, event_type, event_phase_mask, event_chance, event_flags, event_param1, event_param2, event_param3, event_param4, action_type, action_param1, action_param2, action_param3, action_param4, action_param5, action_param6, target_type, target_param1, target_param2, target_param3, target_x, target_y, target_z, target_o, comment) VALUES
(18483,0,0,0,38,0,100,0,1,1,0,0,2,1679,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor's Bodyguard - On Data Set - Set Faction 1679"),
(18483,0,1,0,38,0,100,0,1,1,0,0,49,0,0,0,0,0,0,21,40,0,0,0,0,0,0,"Empoor's Bodyguard - On Data Set - Start Attacking"),
(18483,0,2,0,38,0,100,0,2,2,0,0,2,35,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor's Bodyguard - On Data Set - Set Faction 35"),
(18483,0,3,0,38,0,100,0,2,2,0,0,27,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor's Bodyguard - On Data Set - Stop Combat"),
(18483,0,4,0,0,0,100,0,3000,5000,10000,14000,11,11977,0,0,0,0,0,2,0,0,0,0,0,0,0,"Empoor's Bodyguard - In Combat - Cast 'Rend'"),
(18483,0,5,0,0,0,100,0,5000,7000,15000,20000,11,13730,0,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor's Bodyguard - In Combat - Cast 'Demoralizing Shout'"),
(18483,0,6,0,7,0,100,0,0,0,0,0,80,1848202,2,0,0,0,0,1,0,0,0,0,0,0,0,"Empoor's Bodyguard - On Evade - Run Script");

[Jonne733]

Will do :)

[Seyden]

Holy fuck.. now i see why SAI is so crap :x

[Jonne733]

The things i noticed:

• If you don't turn the quest in to Empoor after you defeated him and instead wait for him to say "I'm leaving now!" and he returns to patrolling, the gossip_menu_option to initiate the fight again is not there any more. The gossip option will come back if you abandon the quest and pick it up again.
• He also doesn't resume patrolling right after saying that line but instead just stands still on the spot. One test I killed his bodyguard, he never returned to Empoor's side and was instead also just standing still further up the road.
  Don't know if that has to do with this script or if it's just a standard behavior for all NPC's with a fixed waypoint route.
• He also becomes stuck as hostile with 1 HP if you try to fight him again without turning the quest in to him. What you have to do to make that happen:
• Accept quest from Tavgren and go talk to Empoor to initate the fight like normal.
• When he reverts back to friendly don't turn the quest in but wait for him to say "I'm leaving now!"
• Abandon the quest, go back to Tavgren and pick it up again, and go to Empoor again.
• Now when you try to fight him he will no longer revert to friendly after getting down to 1 HP.
  If you break combat with him at this point and just wait for him to return to friendly on his own after doing all of the above, the script resets (I guess), and work like is should once again.

[offl]

(1848200,9,1,0,0,0,100,0,0,0,0,0,0,45,1,1,0,0,0,0,19,18483,0,0,0,0,0,0,"Empoor - On Script - Set Data 1 to Empoor's Bodyguard"),
(1848201,9,2,0,0,0,100,0,0,0,0,0,0,45,2,2,0,0,0,0,19,18483,0,0,0,0,0,0,"Empoor - On Script - Set Data 2 to Empoor's Bodyguard"),

You can use the spell 32444 also, it will be more blizzlike but additional changes required

[ZenoX92]

Test it again. I updated my fix. Gossip option should be shown properly now, and Empoor should not get stuck at 1 HP.

As for the second issue, that's the standard behavior.

[ZenoX92]

@offl, spell 32444 has any effect that will actually force Empoor's Bodyguard to leave combat? Or it just does the same than SMART_ACTION_SET_DATA?

[Jonne733]

Confirmed, the "stuck at 1 HP" bug is now fixed and gossip option shows up correctly.
Besides the not returning to patroling waypoint after defeating him, the only small thing now is what I posted here and that is that if you don't accept the quest Wind Trader Lathrai before he says "I'm leaving now!" the yellow "!" should disappear and you will have to fight him again to be able to get it.

[Killyana]

The spell 32444 is a dummy used as set data, if you use it, it could fails if the npc is stunned or silenced, so better to keep the set data at least for the one triggered by: Empoor - Between 0-1% Health

[ZenoX92]

OK, @Killyana.

@Jonne733, that's already fixed. If you don't accept quest "Wind Trader Lathrai" within 120 seconds after he becomes friendly, he will remove questgiver flag and you won't be able to take the quest until you fight him again. Just as you said it should be.

[Jonne733]

Yeah sorry my bad, was using the ".quest add" command to get the quest again, guess that bugged it out somehow so the "!" don't disappear. Tried it with a new char and that worked perfectly.
Good job on the script Zeno :)