Trinitycore: Broken Shore npc spawns

[Igorinus]

sorry for put this here i try to make pull request but i have error Pull request creation failed. Validation failed: Body is too long (maximum is 65536 characters) theni try pastebin and there say it to large so i upload to mega however i have all spawns for that locationbroken shore they are 239 unique npc and 1240 spawns, about guid field from creature i dont include into the query because all have diffrent guids for example in my db i rearrange all the guids from creature and objects because was crazy numbers and i was talk with Traesh about that any way if you wish you can just put NULL in that field and will auto fill in order so please include this spawns. Download here
https://mega.nz/#!t0NliT4T!_eNztnzLyEgy3XS1prh7hzruPX7VRH2wgFtk11bx4lg

[TrinityCoreBot]

This issue is not considered valid because of the following reasons:

• No proper commit hash (revision)

Please read http://bit.ly/tc-issuetracker-and-you and add the missing information to this issue. Thanks.

[Igorinus]

i think the bot need restart, what i did was charity, a thanks will be enough

[Aokromes]

No, bot states you ignored rules of ticket creation. also, the file is ignoring our sql creation rules.

[ghost]

Please read http://bit.ly/tc-issuetracker-and-you and add the missing information to this issue. Thanks

---

edit: I also agree with Aokromes' comment, TrinityCore SQL code style has to be followed:
https://trinitycore.atlassian.net/wiki/spaces/tc/pages/2130102/SQL+Guidelines

if users refuse to follow the guidelines, the so-called contribution is a random dump.

[ghost]

I took the time to edit the contents and make a secret gist out of it.
The file is closer to TC standards, but not completely. First of all, it lacks the guid field and placeholder values for GUID for the spawns.
This is important if you want to create an acceptable SQL for posting as a solution to TrinityCore.
Secondly, it looks like there should be even more columns (TC spawn queries should contain all fields from the creature table).

Lastly, the file lacks documentation and I don't know how verifiable the file contents are.
https://gist.github.com/tkrokli/1f55b918d59e67db475faf92213b4776#file-broken_shore_spawns_unique_entries-sql

You may want to consider posting verifiable sniff to the TC Forum pages instead.
(https://community.trinitycore.org/forum/13-wdbadbsniffs/)

[Aokromes]

( 1, 1220, 7543, 0, 1,0,0,11686,0, -1434.02, 1506.39, -38.8029, 4.84383, 300, 0, 0, 16, 0, 0, 0, 33554432, 0, 0, 0, '', 0),
lol creature id 1, it looks legit.

[ghost]

Yeah, "I don't know how verifiable the file contents are" was an understatement there. :trollface:

---

edit: With all this lack of documentation and custom-looking values, could this be from PTR?

[Aokromes]

no, creature id 1 is custom.

[Igorinus]

about id 1 ignore how ever the spawns are rejected i understand and i dont care if you dont post the charity i made but iam curious in what year Tc will do those spawns not for entire map 1220 just for that tiny island broken shore ? and then in what year will do argus map and all dungeons iam talking just about spawns only?

[ghost]

https://github.com/TrinityCore/TrinityCore/issues/21676#issuecomment-375063257

You may want to consider posting verifiable sniff to the TC Forum pages instead.
(https://community.trinitycore.org/forum/13-wdbadbsniffs/)

[Igorinus]

yea yeah thats why legion have 30% spawns in Tc but about what i ask earlier i know you cant predict exacly a day but to estimate a year please, you think you can ?

[ghost]

That depends entirely on how the TC developers want to update the content of the master branch. I can't predict that, but something should be done within this year, if it fits with what the TC devs want to merge into the DB source.

[Igorinus]

thanks for answer iam sure all the people who get this core first time are exited to test and check legion first time because it is patch 7.3.5 for legion not 3.3.5 but most of the fixes are not about that that patch or at list spawns of npc and objects-loot for them and questing in that zone, are most commits for 3.3.5 maps and a little above which is disappointing how ever from my opinion and i believe in free speech so dont blame meo about that i dont think will happen this year or the next one but thanks for answer again was very fair from you. Even visiting the zone of legion like tourist is bad because it is a huge zones where there is no spawns at list in phase 1 so the tourists wish to see at list something like objects and mobs and i believe that is the basic things in a patch for start.