Trinitycore: [3.3.5] Core/Spells: Green Buff in WSG does nothing

[VincentVanclef]

Description:

The buff applies from the gameobject, to the player, but the buff itself does nothing, no heal, no anything. You can see in combat log nothing is displayed at all.

Image: http://prntscr.com/iqqg6t

I get the buff, animation, but buff does nothing.

Expected behaviour:

should restore some health and mana

Steps to reproduce the problem:

1. Walk into green buff in WSG
2. Notice that the character does not get any spell benefits

Branch(es): 3.3.5

TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/28288698441524081d583af95f19cb1c9fb90387

TDB version: 335.64

Operating system: ubuntu

[VincentVanclef]

@ariel- Is this related to gameobject casting?

[VincentVanclef]

@ariel- Yep, if i do .aura 23493 then it heals me 10% per tick, it is when it gets cast from the object, it does nothing.

EDIT:

The script itself in spell_generic uses Unit* caster = GetCaster(); but the caster is an object

EDIT 2: Found a fix:

Changed GetCaster() to GetOwner()->ToUnit(); and now it works!

in spell_generic

// 23493 - Restoration
// 24379 - Restoration
class spell_gen_restoration : public AuraScript
{
    PrepareAuraScript(spell_gen_restoration);

    void PeriodicTick(AuraEffect const* /*aurEff*/)
    {
        PreventDefaultAction();

        Unit* caster = GetOwner()->ToUnit();
        if (!caster)
            return;

        int32 heal = caster->CountPctFromMaxHealth(10);
        HealInfo healInfo(caster, caster, heal, GetSpellInfo(), GetSpellInfo()->GetSchoolMask());
        caster->HealBySpell(healInfo);

        /// @todo: should proc other auras?
        if (int32 mana = caster->GetMaxPower(POWER_MANA))
        {
            mana /= 10;
            caster->EnergizeBySpell(caster, GetId(), mana, POWER_MANA);
        }
    }

    void Register() override
    {
        OnEffectPeriodic += AuraEffectPeriodicFn(spell_gen_restoration::PeriodicTick, EFFECT_0, SPELL_AURA_PERIODIC_TRIGGER_SPELL);
    }
};

it doesnt show anything in combat log tho but it heals xd

[Killyana]

It could be related to the faction not set correctly to gobs that are not spawned (summoned, or temp spawn like BG spawns)
If you .gob add 180147 the gob will cast the spell on you char
If you .gob add temp 180147 the gob will not cast the spell

[Killyana]

Chickens https://woehead.way-of-elendil.fr/?npc=620 can get the auras from this gobs.
Chickens with Faction= 31 get the aura
Chickens with Faction= 35 doesn't get the aura

[ghost]

@confirm

please if can fixed!

old time is buged this issue

@Shauren
@Treeston

[Jildor]

So, when will @ariel- appear? 😢

[Keader]

It's a good question xD

[ghost]

guys

can give me patch for fix !

:disappointed:

[illfated]

@Hir0shi : This is not a forum.
Please post only useful comments.

[ghost]

okay but , this bug is old and never to fixed :disappointed:

[Killyana]

This issue is not caused by new commit as it's possible to reproduce it in 2 years old core.

[Killyana]

The issue with the spell 23493 https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Spells/spell_generic.cpp#L2844 is not related this traps not being triggered, if you cast the spell on you char it will regen your health but not if casted by a gob as it use caster characteristics to calculate the amount of health.

[Killyana]

Caused by: https://github.com/TrinityCore/TrinityCore/pull/21395#discussion_r279559933

[joshwhedon]

In 3.3.5, trap LOS is checked, because there is no flag indicating it should ignore LOS. As a result they can fail due to LOS issues.

The following can solve it but unsure it is the correct way.

bool IsIgnoringLOSChecks() const
{
switch (type)
{
case GAMEOBJECT_TYPE_BUTTON: return button.losOK == 0;
case GAMEOBJECT_TYPE_QUESTGIVER: return questgiver.losOK == 0;
case GAMEOBJECT_TYPE_CHEST: return chest.losOK == 0;
case GAMEOBJECT_TYPE_GOOBER: return goober.losOK == 0;
case GAMEOBJECT_TYPE_FLAGSTAND: return flagstand.losOK == 0;
case GAMEOBJECT_TYPE_TRAP: return true;
default: return false;
}
}

[illfated]

(just copy-pasting the code above, using MarkDown to indent and highlight the syntax)

bool IsIgnoringLOSChecks() const
{
    switch (type)
    {
        case GAMEOBJECT_TYPE_BUTTON:
            return button.losOK == 0;
        case GAMEOBJECT_TYPE_QUESTGIVER:
            return questgiver.losOK == 0;
        case GAMEOBJECT_TYPE_CHEST:
            return chest.losOK == 0;
        case GAMEOBJECT_TYPE_GOOBER:
            return goober.losOK == 0;
        case GAMEOBJECT_TYPE_FLAGSTAND:
            return flagstand.losOK == 0;
        case GAMEOBJECT_TYPE_TRAP:
            return true;
        default:
            return false;
    }
}

[joshwhedon]

Thank you sorry about the syntax. Tried the insert code button but it still looked like crap :D .

[Aokromes]

https://i.imgur.com/bAx0AKs.png

[illfated]

Notice that this issue happens in Naxxramas too, during the encounter with Heigan the Unclean and his Eruption spell, which does no damage at all.

[jackpoz]

@joshwhedon please check your change ingame and if it works, open a PR

[joshwhedon]

It does work, tested locally, but sorry I don't really have the resources to prepare pull requests for it at the moment. Feel free to use the fix if you want it, or want to raise a pr for it.

[jackpoz]

https://github.com/TrinityCore/TrinityCore/pull/23936

[gonzo1247]

still exist https://github.com/TrinityCore/TrinityCore/issues/23919

[illfated]

Well. I am not too sure about that, although my testing is limited to 1 character/1 game instance (hence using a GM account). Using a gmlevel 3 character for testing, with GM off, seems to receive the buff as expected. Could be different for normal account characters, but I don't know. Heigan & Noth spell issues are confirmed, though.