Trinitycore: [Master] Incorrect ExtentedCost / Price for npc_vendor

[DoctorKraft]

Description:

All items with only price at vendor have a ExtentedCost so he don't display price required. ExtentedCost are unused because core get value in BuyPrice (ItemSparse.db2) but this value are not correct per moment because some items are the field at 0.

I think ItemExtentedCost structure are outdated and contain value for price, when i check ExtentedCost for a item with only price all rows are 0.

Anyone have an idea how to check the structure DB2? I can open a PR if i found a solution

Branch(es):

master

TC rev. hash/commit:

https://github.com/TrinityCore/TrinityCore/commit/c0abcc838be68f340f8276e6ba2c430276779b5b

[Kodekc]

The table works correctly, you just need to fill in the data in it

[Kodekc]

There are ExtendedCost that are empty, which require payment in gold. It looks like us need to create a separate table and fill in the data there.
on 6.x in ItemExtendedCost there was an additional field RequiredMoney, in 7.x it was removed

[DoctorKraft]

This remove are strange!
But yes, or directly get price in ListInventory but i don't think it's good a idea with discount price.

[ForesterDev]

Maybe they move this column in other db2 file?

[DoctorKraft]

I have take a look and found nothing for the moment, the only it's BuyPrice in ItemSparse.db2 but some items don't have value. Maybe blizz hotfix each item buy price? ><

[Shauren]

need a specific item example

[Shauren]

@shauren declines the summon, continues phasing instead

[Kodekc]

Kodekc vanish

[funjoker]

need a specific item example

everyone ignores his request D:

[Kodekc]

@funjoker I gave an example (Already deleted), but here jokes are joking. I'm leaving

[Shauren]

If you deleted it then how on earth is ANYONE (not just me) supposed to fix it in future?

[Kodekc]

I expect cooperative assistance here, not trolling. Again an example:

-- Krom Stoutarm <Heirloom Curator>
UPDATE `creature` SET `position_x`='-4619.922', `position_y`='-1300.316', `position_z`='503.4649', `orientation`='4.498659' WHERE  `guid`=307755;
UPDATE `creature_template` SET `npcflag`='131' WHERE  `entry`=6294;
DELETE FROM `npc_vendor` WHERE  `entry`=6294;
INSERT INTO `npc_vendor` (`entry`, `slot`, `item`, `maxcount`, `ExtendedCost`, `type`, `PlayerConditionID`, `IgnoreFiltering`, `VerifiedBuild`) VALUES
(6294, 61, 122666, 0, 5567, 1, 0, 0, 25996), -- 122666
(6294, 60, 122668, 0, 5567, 1, 0, 0, 25996), -- 122668
(6294, 59, 122662, 0, 5567, 1, 0, 0, 25996), -- 122662
(6294, 58, 122664, 0, 5567, 1, 0, 0, 25996), -- 122664
(6294, 57, 122667, 0, 5567, 1, 0, 0, 25996), -- 122667
(6294, 56, 122663, 0, 5567, 1, 0, 0, 25996), -- 122663
(6294, 55, 122362, 0, 5567, 1, 0, 0, 25996), -- 122362
(6294, 54, 122361, 0, 5567, 1, 0, 0, 25996), -- 122361
(6294, 53, 122530, 0, 5567, 1, 0, 0, 25996), -- 122530
(6294, 52, 122371, 0, 5567, 1, 0, 0, 25996), -- 122371
(6294, 50, 122391, 0, 5564, 1, 0, 0, 25996), -- 122391
(6294, 49, 122392, 0, 5564, 1, 0, 0, 25996), -- 122392
(6294, 48, 122390, 0, 5564, 1, 0, 0, 25996), -- 122390
(6294, 47, 122351, 0, 5565, 1, 0, 0, 25996), -- 122351
(6294, 46, 122350, 0, 5565, 1, 0, 0, 25996), -- 122350
(6294, 45, 122385, 0, 5565, 1, 0, 0, 25996), -- 122385
(6294, 44, 122354, 0, 5565, 1, 0, 0, 25996), -- 122354
(6294, 43, 122389, 0, 5565, 1, 0, 0, 25996), -- 122389
(6294, 42, 122369, 0, 5565, 1, 0, 1, 25996), -- 122369
(6294, 41, 122367, 0, 5565, 1, 0, 1, 25996), -- 122367
(6294, 40, 122364, 0, 5565, 1, 0, 0, 25996), -- 122364
(6294, 39, 122366, 0, 5566, 1, 0, 0, 25996), -- 122366
(6294, 38, 122352, 0, 5566, 1, 0, 0, 25996), -- 122352
(6294, 37, 122363, 0, 5566, 1, 0, 0, 25996), -- 122363
(6294, 36, 122349, 0, 5566, 1, 0, 0, 25996), -- 122349
(6294, 35, 122353, 0, 5566, 1, 0, 0, 25996), -- 122353
(6294, 34, 122386, 0, 5566, 1, 0, 0, 25996), -- 122386
(6294, 33, 122365, 0, 5566, 1, 0, 0, 25996), -- 122365
(6294, 32, 122368, 0, 5566, 1, 0, 0, 25996), -- 122368
(6294, 31, 140773, 0, 5565, 1, 0, 0, 25996), -- 140773
(6294, 30, 122387, 0, 5563, 1, 0, 0, 25996), -- 122387
(6294, 29, 127010, 0, 5563, 1, 0, 0, 25996), -- 127010
(6294, 28, 122381, 0, 5563, 1, 0, 0, 25996), -- 122381
(6294, 27, 122380, 0, 5563, 1, 0, 0, 25996), -- 122380
(6294, 26, 122379, 0, 5563, 1, 0, 0, 25996), -- 122379
(6294, 25, 122382, 0, 5563, 1, 0, 0, 25996), -- 122382
(6294, 24, 122383, 0, 5563, 1, 0, 0, 25996), -- 122383
(6294, 23, 122384, 0, 5563, 1, 0, 0, 25996), -- 122384
(6294, 22, 122388, 0, 5564, 1, 0, 0, 25996), -- 122388
(6294, 21, 122355, 0, 5564, 1, 0, 0, 25996), -- 122355
(6294, 20, 122373, 0, 5564, 1, 0, 0, 25996), -- 122373
(6294, 19, 122372, 0, 5564, 1, 0, 0, 25996), -- 122372
(6294, 18, 122356, 0, 5564, 1, 0, 0, 25996), -- 122356
(6294, 17, 122357, 0, 5564, 1, 0, 0, 25996), -- 122357
(6294, 16, 122375, 0, 5564, 1, 0, 0, 25996), -- 122375
(6294, 15, 122374, 0, 5564, 1, 0, 0, 25996), -- 122374
(6294, 14, 122359, 0, 5563, 1, 0, 0, 25996), -- 122359
(6294, 13, 122358, 0, 5564, 1, 0, 0, 25996), -- 122358
(6294, 12, 122377, 0, 5564, 1, 0, 0, 25996), -- 122377
(6294, 11, 122376, 0, 5564, 1, 0, 0, 25996), -- 122376
(6294, 10, 122360, 0, 5564, 1, 0, 0, 25996), -- 122360
(6294, 9, 122378, 0, 5564, 1, 0, 0, 25996), -- 122378
(6294, 8, 150743, 0, 6196, 1, 0, 0, 25996), -- 150743
(6294, 7, 150746, 0, 6196, 1, 0, 0, 25996), -- 150746
(6294, 6, 151615, 0, 6194, 1, 0, 0, 25996), -- 151615
(6294, 5, 151614, 0, 6195, 1, 0, 0, 25996), -- 151614
(6294, 4, 122341, 0, 5556, 1, 0, 0, 25996), -- 122341
(6294, 3, 122340, 0, 5555, 1, 0, 0, 25996), -- 122340
(6294, 2, 122339, 0, 5546, 1, 0, 0, 25996), -- 122339
(6294, 1, 122338, 0, 5545, 1, 0, 0, 25996); -- 122338

[DoctorKraft]

Here an example with a vendor of argus, only sell with gold

DELETE FROM `npc_vendor` WHERE (`entry`=127151 AND `item`=152725 AND `ExtendedCost`=6069 AND `type`=1) OR (`entry`=127151 AND `item`=152658 AND `ExtendedCost`=6069 AND `type`=1) OR (`entry`=127151 AND `item`=151708 AND `ExtendedCost`=6066 AND `type`=1) OR (`entry`=127151 AND `item`=151707 AND `ExtendedCost`=6068 AND `type`=1) OR (`entry`=127151 AND `item`=152618 AND `ExtendedCost`=6066 AND `type`=1) OR (`entry`=127151 AND `item`=152797 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152796 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152795 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152794 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152793 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152791 AND `ExtendedCost`=6241 AND `type`=1) OR (`entry`=127151 AND `item`=152669 AND `ExtendedCost`=6107 AND `type`=1) OR (`entry`=127151 AND `item`=152964 AND `ExtendedCost`=6244 AND `type`=1) OR (`entry`=127151 AND `item`=153027 AND `ExtendedCost`=6108 AND `type`=1) OR (`entry`=127151 AND `item`=153039 AND `ExtendedCost`=6298 AND `type`=1);
INSERT INTO `npc_vendor` (`entry`, `slot`, `item`, `maxcount`, `ExtendedCost`, `type`, `PlayerConditionID`, `IgnoreFiltering`, `VerifiedBuild`) VALUES
(127151, 17, 152725, 0, 6069, 1, 0, 0, 25864),
(127151, 16, 152658, 0, 6069, 1, 0, 0, 25864),
(127151, 15, 151708, 0, 6066, 1, 0, 0, 25864),
(127151, 14, 151707, 0, 6068, 1, 0, 0, 25864),
(127151, 13, 152618, 0, 6066, 1, 0, 0, 25864),
(127151, 12, 152797, 0, 6241, 1, 0, 0, 25864),
(127151, 11, 152796, 0, 6241, 1, 0, 0, 25864),
(127151, 10, 152795, 0, 6241, 1, 0, 0, 25864),
(127151, 9, 152794, 0, 6241, 1, 0, 0, 25864),
(127151, 8, 152793, 0, 6241, 1, 0, 0, 25864),
(127151, 7, 152791, 0, 6241, 1, 0, 0, 25864),
(127151, 6, 152669, 0, 6107, 1, 0, 0, 25864),
(127151, 4, 152964, 0, 6244, 1, 0, 0, 25864),
(127151, 2, 153027, 0, 6108, 1, 0, 0, 25864),
(127151, 1, 153039, 0, 6298, 1, 0, 0, 25864);

If you look for exemple first item with ExtentedCost 6069, all rows of db2 are empty

[funjoker]

maybe they added a price override :/