Trinitycore: Vampiric Touch Deals too much damage

Created on 11 Feb 2018 · 34Comments · Source: TrinityCore/TrinityCore

Description:

Vampiric Touch Deals too much damage.

It should deal maximum 10k-15k damage with critical but now it deals about 30K-40K crit and 10k-15k non-crit ( BiS Gear )

vampiric_touch

Branch(es): 3.3.5

TC rev. hash/commit: 638cb33

TDB version: TDB 335.63

Operating system: Debian 9

Branch-3.3.5a Comp-C++Script Comp-Core Sub-Spells

Source

tje3d

All 34 comments

Same happens with Warlock's Unstable Affliction spell.
warlock

tje3d on 11 Feb 2018

Unstable Affliction should does alot of damage if someone dispel it.
But 18k looks so much o.o

Keader on 11 Feb 2018

@Keader 18K non-crit 😁

tje3d on 11 Feb 2018

@tje3d: Try again after the fix, in my case the problem still continues.

Gooyeth on 12 Feb 2018

Still bug, causes damage of 20k.

Gooyeth on 14 Feb 2018

Confirmed in eb7d22d

Strazhnik on 21 Feb 2018

Cannot reproduce on rev. eb7d22d23eed
Try with a new char without buffs, maybe it's caused by something else.

Killyana on 21 Feb 2018

The more spd, the higher the damage. If dispel at 1000 spd= 7000 damage in 1000 resilience.

Strazhnik on 21 Feb 2018

We have no data on this spell that can confirm or dismiss the bug. It's supposed to scale on tick damage and do the equivalent of 8 ticks at once

ariel- on 21 Feb 2018

1000×1.2+1360= 2560 without talents
http://wowwiki.wikia.com/wiki/Spell_power_coefficient

Strazhnik on 21 Feb 2018

Looks correct for me https://imgur.com/a/wP6wM
Values matchs DrDamage calculations.

Killyana on 21 Feb 2018

@Killyana the issue description is garbage but this is about the on-dispel damage, not ticks

@Strazhnik Please provide:
.pdump of spriest you used to test
.pdump of target you used to test
damage value you saw in your test
and how much damage you think it should do for spriest you used to test

Shauren on 21 Feb 2018

About the on-Dispel damage. Test without talents and etc.
spriest:
spd=2619
paladin:
resilience=1061
Vampiric touch dispel=9736
I think it shoul be=(2619*1.2+1360)-22.51%=3489

Strazhnik on 21 Feb 2018

170 * 8 = 1360 is tick base damage, you're not factoring in spell power coefficient from the ticks. That's why I think scaling of 120% is wrong for this spell and that it should use tick bonus.

SPELL_ATTR4_FIXED_DAMAGE is causing it not being affected by resilience; but unmitigated damage seems ok:

Tick damage: 170 + (2619 * 0.4) = 1217.6
Damage for 8 ticks: 8 * 1217.6 = 9740.8, which seems spot on with your 9736 result.

Missing 22.51% damage reduction from resil = 0.7749 * 9740.8 = 7548.15

ariel- on 21 Feb 2018

Tick damage = 106 * 8 = 850 is tick base damage;
106 + (2619 * 0.4) = 1154;
Damage for 8 tick = 8 * 1154 = 9232
If dispel this spell base damage = 1360 (2 part of the spell);
Dispel damage = (2619 * 1.2 + 1360) - 22.51% = 3489

Strazhnik on 21 Feb 2018

It needs to be fixed damage otherwise it will double dip on resilience. Combustion had the same issue early in Cata and that's how they fixed it.

I have very faint memories about the damage numbers for dispelling VT in wrath on retail, but there's a reason no one did that unless with an absorb shield up, or as a holy pally. It hits hard, like UA. {{ citation needed }}

Warpten on 21 Feb 2018

Tick damage = 106 * 8 = 850 is tick base damage;
106 + (2619 * 0.4) = 1154;

I don't know where are you getting the 106 from.

ID - 48160 Vampiric Touch (Rank 5)
=================================================
(...)

Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 170 Bonus = 0,40
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)
Aura Id 3 (SPELL_AURA_PERIODIC_DAMAGE), value = 170, misc = 0 (0), miscB = 0, periodic = 3000

170 is the base damage without sp

so, get the damage per tick, and multiply it by 8 you get the amount of damage you should get on dispel

It needs to be fixed damage otherwise it will double dip on resilience. Combustion had the same issue early in Cata and that's how they fixed it.

Already added the fixed damage attribute however the calculation in AuraEffect::GetAmount only takes caster bonuses, resilience reduction is applied per tick. As the dispel reaction is from a script, I need to take into account victim taken bonuses (which includes resilience)

ariel- on 22 Feb 2018

Well I'm down for whatever as long as shadow doesn't break :(

Warpten on 22 Feb 2018

😄1

@ariel-
https://wotlk-twinhead.twinstar.cz/?spell=48160
170 damage every 3 seconds.
In 15 sec = 5 tick.

Causes 850 Shadow damage over 15sec. 170 * 5 = 850.
170 + (2619 * 0.4) = 1218 * 5 tick = 6088 (without resil)
If the Vampiric Touch is dispelled it will cause 1360 damage to the afflicted target.
(2619 * 1.2 + 1360) = 4502 (without resil)

http://wowwiki.wikia.com/wiki/Spell_power_coefficient
[Vampiric Touch] | 40.0% (per tick; totaling 200%) | = 5 tick
[Vampiric Touch] (Dispelled) | 120%

Now i tested it and result = 5 tick (TrinityCore)
Need correctable damage.

Strazhnik on 22 Feb 2018

Friendly reminder that tooltip in wrath are not in the least bit accurate when it comes to damage valued

Warpten on 22 Feb 2018

Also this:

there's a reason no one did that unless with an absorb shield up, or as a holy pally. It hits hard, like UA. {{ citation needed }}

Wowwiki also says:
>

If you take per tick coeff (20%) and multiply it by 9 (UA dispel does damage of 9 ticks), you get 180%
The same mechanic applies to Vampiric Touch, per tick coeff is 40%, you multiply it by 8, result is 320%

ariel- on 22 Feb 2018

👍1

@ariel-
I tested the damage Vampiric Touch with 6000 spd (without resil)
1) Tick damage = 2577 * 5 = 12885
2) Dispelled damage = 20616
This is normal?

Strazhnik on 25 Feb 2018

It's * 8 instead of * 5. And you have a very high amount of spell power

ariel- on 25 Feb 2018

In combat log 5 tick

Strazhnik on 25 Feb 2018

It will always deal full damage of 8 ticks, despite if you let it tick for less

ariel- on 25 Feb 2018

Are you sure about that? I don't have spellwork with me right now but according to https://wotlk-twinhead.twinstar.cz/?spell=48160 this rank has a duration of 15 seconds with ticks every 3 seconds - that would give it 5 ticks, not 8

Shauren on 26 Feb 2018

ID - 48160 Vampiric Touch (Rank 5)
=================================================
Description: Causes $o2 Shadow damage over $d to your target and causes up to 10 party or raid members to gain 1% of their maximum mana per 5 sec when you deal damage from Mind Blast. In addition, if the Vampiric Touch is dispelled it will cause $*8;s2 damage to the afflicted target.
ToolTip: $s2 Shadow damage every $t2 seconds. Priest's party or raid members gain 1% of their maximum mana per 5 sec when the priest deals damage from Mind Blast.
Category = 0, SpellIconID = 2213, activeIconID = 0, SpellVisual = (3582,0)
Family SPELLFAMILY_PRIEST, flag [0] 0x00000000 [1] 0x00000400 [2] 0x00000400

SpellSchoolMask = 32 (SPELL_SCHOOL_MASK_SHADOW)
DamageClass = 1 (SPELL_DAMAGE_CLASS_MAGIC)
PreventionType = 1 (SPELL_PREVENTION_TYPE_SILENCE)
=================================================
AttributesEx3: 0x04000000 (SPELL_ATTR3_CAN_PROC_WITH_TRIGGERED)
AttributesEx6: 0x00800000 (SPELL_ATTR6_UNK23)
=================================================
Skill (Id 78) "Shadow Magic"
    ReqSkillValue 1, Forward Spell = 0, MinMaxValue (0, 0), CharacterPoints (0, 0)Spell Level = 80, base 80, max 84, maxTarget 0

Category = 0
DispelType = 1 (DISPEL_MAGIC)
Mechanic = 0 (MECHANIC_NONE)
SpellRange: (Id 4) "Medium Range":
    MinRange = 0, MinRangeFriendly = 0
    MaxRange = 30, MaxRangeFriendly = 30

CastingTime (Id 16) = 1,50
RecoveryTime: 0 ms, CategoryRecoveryTime: 0 ms
StartRecoveryCategory = 133, StartRecoveryTime = 1500,00 ms
Duration: ID (8)  15000, 0, 15000
Power POWER_MANA, Cost 16 %
Interrupt Flags: 0x0000000F, AuraIF 0x00000000, ChannelIF 0x00000000
Proc flag 0x00020000, chance = 100, charges - 0
=================================================
  17 Taken magic spell damage
=================================================
Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 2
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 2, misc = 0 (0), miscB = 0, periodic = 0

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 170
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)
Aura Id 3 (SPELL_AURA_PERIODIC_DAMAGE), value = 170, misc = 0 (0), miscB = 0, periodic = 3000

Effect 2: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 0
Targets (6, 0) (TARGET_UNIT_TARGET_ENEMY, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 0, misc = 0 (0), miscB = 0, periodic = 0