Trinitycore: Core/Vmaps: can not mount outdoors in some areas

[Gooyeth]

Description:

The vmaps does not recognize some outdoor areas.

Current behaviour:

Warsong Gulch: http://oi66.tinypic.com/fodq1h.jpg

Branch(es): 3.3.5

TC rev. hash/commit: 1acfefb973895b0e3df3c8d9b43b920d2a1b5392

TDB version: TDB 335.63

Operating system: Debian 9

[ghost]

You have only mentioned 1 specific zone/area, a PvP zone. Can you reproduce this in other maps?

[Cyclone47]

Not sure if related, but at Krasus Landing in Dalaran it's sometimes impossible to use your flying mount. Relogging fixes this.

[Golrag]

Could you do a .gps to check your position and tell me if your z is above/under your ground/floor ? I have a feeling the removal of those 2.0fs is the cause of it.

[Gooyeth]

@tkrokli: So far no.

@Golrag: Above = ~360 / Under: ~330

[VincentVanclef]

could this get some love? its really game breaking

[Warpten]

Serverside position clipping through floor and falling to level below @Golrag ?

[Golrag]

Yea I think that's the issue, adding collision height to z at the point it is calculated should fix it then, will see if I have time this evening

[VincentVanclef]

Awesome!

[Treeston]

repro coordinates 1407.696045 1464.369263 347.504517 map 489 (WSG)
floorZ is 347.504761 (slightly above the actual z), which triggers this bug

[Treeston]

x 1407.696045 y 1464.369263 z 347.504517 mapHeight 347.504761 vmapData.floorZ 336.611481
so the player is _slightly_ below the (not-quite-correct) gridmap floor, and the core uses area data (including outdoor state) of the vmap floor below instead (the WSG tunnel)