Trinitycore: Anub'rekhan not linked to his Crypt Guards.

[Pugnadeus]

Description:

If I am inside Naxxramas, I can pull one of Anub'rekhan's Crypt Guards without aggroing the other Crypt Guard or Anub'rekhan himself.

Current behaviour:

It is possible to aggro only Anub'rekhan or one of the Crypt Guards if we aggro them from the side.

Expected behaviour:

Pulling any of the Crypt Guards or Anub'rekhan himself will result in all of them getting aggroed.

Steps to reproduce the problem:

1. CHANGEME Step 1 include entries of affected creatures / items / quests with a link to the relevant wowhead page.
2. Step 2
3. Step 3

Branch(es):

3.3.5, I don't know which branch

TC rev. hash/commit:

TrinityCore rev. 607034064f04 2017-10-07 17:13:34 +0200 (3.3.5 branch) (Win64, RelWithDebInfo, Static) (authserver)

TDB version: TDB_full_world_335.63_2017_04_18

Operating system: Windows 10

[Killyana]

Something is wrong with the action SMART_ACTION_CALL_FOR_HELP if we use it with the event on aggro
This will work

UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=321;
DELETE FROM `smart_scripts` WHERE `entryorguid`=321 AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(321,0,0,0,0,0,100,1,1000,1000,0,0,39,80,1,0,0,0,0,1,0,0,0,0,0,0,0,"IC- call for help");

This will not work even if the text is displayed npc around will not enter the combat

UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=321;
DELETE FROM `smart_scripts` WHERE `entryorguid`=321 AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(321,0,0,0,4,0,100,0,0,0,0,0,39,80,1,0,0,0,0,1,0,0,0,0,0,0,0,"In aggro- call for help");

This will also not work

UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=321;
DELETE FROM `smart_scripts` WHERE `entryorguid`=321 AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(321,0,0,0,0,0,100,1,0,0,0,0,39,80,1,0,0,0,0,1,0,0,0,0,0,0,0,"IC- call for help");

It looks like the npc call for help any other npc (allies) around it on aggro natively, and this call override the one used by the SAI if the delay between this 2 calls <1secs

[Pugnadeus]

So I should post the top one which you said will work in the querry, or will it be updated in the official TC?

[Pugnadeus]

One more thing @Killyana, the query you added does work if Anub'rekhan is pulled first, however it does not work if his Crypt Guards are pulled first, I can still pull each one of them from the side, kill them and then engage the boss without adds at the start.

[Killyana]

No this must be fixed in core side, also when you pull the boss a set combat with zone is called and the 2 guards will enter the combat.

[ghost]

Maybe @Wyreth would like to pick up the challenge to see if he can find out what can be done about that action in the SAI core source?

[Pugnadeus]

It would be incredible if someone could start working on this issue, since it creates a lot of problem in MC and sub-raids on my server which is hosting vanilla as end-game content, is there a forum where I can ask some more complicated questions about TC?

[lachtanek]

Was digging into this issue earlier, call for help only works when creature has a victim so its kinda buggy for some reason when used with aggro event (didnt have time to check why, through)
You can use SET_IN_COMBAT_WITH_ZONE (38) with target CREATURE_GUID (10), but it may be a bit of a hack.

[Killyana]

The easiest way is to delay the call of help by 1 secs.

[lachtanek]

@Killyana I think thats even more hacky solution than mine tho :D

[Wyreth]

@lachtanek maybe not - it might sound strange, but in some of my almost expired memories from WotLK retail I recall creatures waiting 1-2 seconds before answering a call for help :P

[lachtanek]

@Wyreth alright, fair enough, still weird tho

[Killyana]

Yes it makes sense, the text is displayed, then after 1-2 secs npcs will enter combat.

[Keader]

Just put call of combat with boss, when Crypt Guards enter in combat
(you can do it using EnterCombat(Unit* who) in a ScriptedAI)

[Killyana]

Yes but in this case the SAI action mut be fixed.

[Pugnadeus]

Will an issue like this be fixed in the 3.3.5 branch or will I have to do this manually?

[ghost]

Ideally it will be fixed in the TC source (3.3.5 / master), but it depends on someone coming up with a working solution.

[lachtanek]

One solution would be to add second optional parameter victim to Creature::CallForHelp. If noone comes up with better solution, I will open a PR with it.

[offl]

Why nobody talks about formations? :D

[lachtanek]

Sometimes you can't put creatures into formations like when they already are in one or, in this case, they're temporary summons

[offl]

That's why I had a feeling that I am stupid and missed something, because four days and nobody's talking about formations.. there must be a reason.

[Pugnadeus]

I'm new to Trinity, but how many people are working on it?

[ccrs]

Since working implies, by definition, some sort of revenue, 0

[ghost]

Yes, it all depends on how you define "working" or what you actually want to know.
There is a certain number of members in the TrinityCore organization, but some are inactive
and some are more active than others. And like ccrs said, none of them receive a salary.

[Treeston]

If you wanna pay me a full-time job I'll gladly work on this silly project.

Until then, you get fixes when they happen.

[Treeston]

closed by 79f0e55

[Pugnadeus]

Apologies for the attitude in the past @Treeston , I didn't want to come off that way, I'm very grateful for the fix!